Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: sky/engine/core/page/PageAnimator.cpp

Issue 880713003: Rename scheduleAnimation() to scheduleVisualUpdate(). (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: rebase. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/page/PageAnimator.h ('k') | sky/engine/platform/HostWindow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/page/PageAnimator.cpp
diff --git a/sky/engine/core/page/PageAnimator.cpp b/sky/engine/core/page/PageAnimator.cpp
index 64b0fbdf4b86eb86ca277613a14f846834354bb7..89aeae4c9289414b3682ca1a299858dbf0e3e3b1 100644
--- a/sky/engine/core/page/PageAnimator.cpp
+++ b/sky/engine/core/page/PageAnimator.cpp
@@ -17,7 +17,6 @@ namespace blink {
PageAnimator::PageAnimator(Page* page)
: m_page(page)
- , m_animationFramePending(false)
, m_servicingAnimations(false)
, m_updatingLayoutAndStyleForPainting(false)
{
@@ -25,7 +24,6 @@ PageAnimator::PageAnimator(Page* page)
void PageAnimator::serviceScriptedAnimations(double monotonicAnimationStartTime)
{
- m_animationFramePending = false;
TemporaryChange<bool> servicing(m_servicingAnimations, true);
Vector<RefPtr<Document> > documents;
@@ -43,10 +41,9 @@ void PageAnimator::serviceScriptedAnimations(double monotonicAnimationStartTime)
void PageAnimator::scheduleVisualUpdate()
{
- // FIXME: also include m_animationFramePending here. It is currently not there due to crbug.com/353756.
if (m_servicingAnimations || m_updatingLayoutAndStyleForPainting)
return;
- m_page->chrome().scheduleAnimation();
+ m_page->chrome().scheduleVisualUpdate();
}
void PageAnimator::updateLayoutAndStyleForPainting(LocalFrame* rootFrame)
« no previous file with comments | « sky/engine/core/page/PageAnimator.h ('k') | sky/engine/platform/HostWindow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698