mojo/services/network/network_service_impl.cc - Issue 880613005: De-Clientize UDPSocket service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/network/network_service_impl.cc

Issue 880613005: De-Clientize UDPSocket service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rollin

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/network/network_service_impl.cc

diff --git a/mojo/services/network/network_service_impl.cc b/mojo/services/network/network_service_impl.cc

index 64eb3370f89054627ec2cd3bd732dd7c84345958..ed4db49930c1425e4775b12c00f84958ff9bd866 100644

--- a/mojo/services/network/network_service_impl.cc

+++ b/mojo/services/network/network_service_impl.cc

@@ -66,8 +66,9 @@ void NetworkServiceImpl::CreateTCPConnectedSocket(

callback.Run(MakeNetworkError(net::ERR_NOT_IMPLEMENTED), NetAddressPtr());

}

-void NetworkServiceImpl::CreateUDPSocket(InterfaceRequest<UDPSocket> socket) {

- BindToRequest(new UDPSocketImpl(), &socket);

+void NetworkServiceImpl::CreateUDPSocket(InterfaceRequest<UDPSocket> request) {

+ // The lifetime of this UDPSocketImpl is bound to that of the underlying pipe.

+ new UDPSocketImpl(request.Pass());

}

} // namespace mojo