Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: mojo/services/network/public/cpp/udp_socket_wrapper.cc

Issue 880613005: De-Clientize UDPSocket service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rollin
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/network/public/cpp/udp_socket_wrapper.cc
diff --git a/mojo/services/network/public/cpp/udp_socket_wrapper.cc b/mojo/services/network/public/cpp/udp_socket_wrapper.cc
index 4510c273f17fdc6fadbee9095c0360ce20407248..9c083f887806cea17f3f45508419117a3ac29581 100644
--- a/mojo/services/network/public/cpp/udp_socket_wrapper.cc
+++ b/mojo/services/network/public/cpp/udp_socket_wrapper.cc
@@ -47,7 +47,8 @@ UDPSocketWrapper::SendRequest::SendRequest() {}
UDPSocketWrapper::SendRequest::~SendRequest() {}
UDPSocketWrapper::UDPSocketWrapper(UDPSocketPtr socket)
- : socket_(socket.Pass()),
+ : binding_(this),
+ socket_(socket.Pass()),
max_receive_queue_size_(kDefaultReceiveQueueSlots),
max_pending_sends_(1),
current_pending_sends_(0) {
@@ -57,7 +58,8 @@ UDPSocketWrapper::UDPSocketWrapper(UDPSocketPtr socket)
UDPSocketWrapper::UDPSocketWrapper(UDPSocketPtr socket,
uint32_t receive_queue_slots,
uint32_t requested_max_pending_sends)
- : socket_(socket.Pass()),
+ : binding_(this),
+ socket_(socket.Pass()),
max_receive_queue_size_(receive_queue_slots),
max_pending_sends_(1),
current_pending_sends_(0) {
@@ -159,7 +161,9 @@ void UDPSocketWrapper::OnReceived(NetworkErrorPtr result,
}
void UDPSocketWrapper::Initialize(uint32_t requested_max_pending_sends) {
- socket_.set_client(this);
+ UDPSocketReceiverPtr receiver_proxy;
+ binding_.Bind(&receiver_proxy);
jamesr 2015/01/28 20:48:37 this isn't wrong, but it's a bit confusing (imho).
+ socket_->SetReceiver(receiver_proxy.Pass());
socket_->NegotiateMaxPendingSendRequests(
requested_max_pending_sends,
Callback<void(uint32_t)>(

Powered by Google App Engine
This is Rietveld 408576698