Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880603004: Merge to XFA: Add namespace and-re-arrange PDFium's local copy of /base. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merge to XFA: Add namespace and-re-arrange PDFium's local copy of /base. Original revieww URL: https://codereview.chromium.org/900753002 TBR=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/35425896b07b5124651c249d6ce29285cf71ea3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -1234 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxcrt/fx_basic_array.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxcrt/fx_safe_types.h View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/BUILD.gn View 2 chunks +9 lines, -9 lines 0 comments Download
A + third_party/base/logging.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + third_party/base/macros.h View 1 chunk +31 lines, -31 lines 0 comments Download
A + third_party/base/numerics/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/base/numerics/safe_conversions.h View 2 chunks +5 lines, -3 lines 0 comments Download
A + third_party/base/numerics/safe_conversions_impl.h View 2 chunks +5 lines, -3 lines 0 comments Download
A + third_party/base/numerics/safe_math.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + third_party/base/numerics/safe_math_impl.h View 3 chunks +5 lines, -3 lines 0 comments Download
A + third_party/base/template_util.h View 2 chunks +5 lines, -3 lines 0 comments Download
D third_party/logging.h View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/macros.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/numerics/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/numerics/safe_conversions.h View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/numerics/safe_conversions_impl.h View 1 chunk +0 lines, -217 lines 0 comments Download
D third_party/numerics/safe_math.h View 1 chunk +0 lines, -271 lines 0 comments Download
D third_party/numerics/safe_math_impl.h View 1 chunk +0 lines, -502 lines 0 comments Download
D third_party/template_util.h View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/third_party.gyp View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tom Sepez
Merging.
5 years, 10 months ago (2015-02-05 18:03:03 UTC) #1
Tom Sepez
5 years, 10 months ago (2015-02-05 18:03:29 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
35425896b07b5124651c249d6ce29285cf71ea3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698