Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(30)

Issue 8806015: Changes to support a second VM. (Closed)

Created:
6 years ago by podivilov
Modified:
5 years, 10 months ago
Reviewers:
vsm
Visibility:
Public.

Description

Changes to support a second VM. With this patch, V8 may co-exist and share the DOM with another engine. JSC is only partially refactored right now.

Patch Set 1 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+792 lines, -714 lines) Patch
M Source/WebCore/bindings/js/ScriptCallStackFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/bindings/js/ScriptSourceCode.h View 1 chunk +4 lines, -1 line 0 comments Download
A + Source/WebCore/bindings/public/ScheduledAction.h View 3 chunks +12 lines, -32 lines 0 comments Download
A Source/WebCore/bindings/public/ScriptValueDeserializer.h View 1 chunk +90 lines, -0 lines 0 comments Download
A + Source/WebCore/bindings/public/ScriptValueSerializer.h View 3 chunks +16 lines, -30 lines 0 comments Download
D Source/WebCore/bindings/v8/ScheduledAction.h View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/WebCore/bindings/v8/ScheduledAction.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptCallStackFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/bindings/v8/ScriptController.h View 3 chunks +16 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptController.cpp View 5 chunks +31 lines, -0 lines 1 comment Download
M Source/WebCore/bindings/v8/ScriptSourceCode.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/v8/SerializedScriptValue.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/v8/SerializedScriptValue.cpp View 20 chunks +404 lines, -336 lines 0 comments Download
A + Source/WebCore/bindings/v8/V8ScheduledAction.h View 4 chunks +8 lines, -7 lines 0 comments Download
A + Source/WebCore/bindings/v8/V8ScheduledAction.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/dom/ScriptElement.cpp View 2 chunks +10 lines, -1 line 0 comments Download
M Source/WebCore/dom/make_names.pl View 9 chunks +79 lines, -8 lines 0 comments Download
M Source/WebCore/inspector/ConsoleMessage.cpp View 2 chunks +5 lines, -17 lines 0 comments Download
M Source/WebCore/inspector/InspectorConsoleAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorInstrumentation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/ScriptArguments.h View 1 chunk +34 lines, -9 lines 0 comments Download
M Source/WebCore/inspector/ScriptArguments.cpp View 1 chunk +45 lines, -26 lines 0 comments Download
M Source/WebCore/page/Console.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/page/Settings.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/WebCore/page/Settings.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
Trybot results:

Messages

Total messages: 1 (0 generated)
vsm
6 years ago (2011-12-05 17:20:28 UTC) #1
http://codereview.chromium.org/8806015/diff/2001/Source/WebCore/bindings/v8/S...
File Source/WebCore/bindings/v8/ScriptController.cpp (right):

http://codereview.chromium.org/8806015/diff/2001/Source/WebCore/bindings/v8/S...
Source/WebCore/bindings/v8/ScriptController.cpp:36: #include "DartController.h"
We should refactor ScriptController to bindings/public and rename this to
JavaScriptController.  There should be no references to Dart here after that.

Powered by Google App Engine
This is Rietveld 0eb02b776