Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(130)

Issue 88053: implement remaining tab events (except for onTabUpdated). (Closed)

Created:
11 years, 9 months ago by rafaelw
Modified:
9 years, 8 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

implement remaining tab events (except for onTabUpdated). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14255

Patch Set 1 #

Total comments: 12

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -15 lines) Patch
M chrome/browser/extensions/extension_browser_event_router.h View 1 2 chunks +5 lines, -0 lines 1 comment Download
M chrome/browser/extensions/extension_browser_event_router.cc View 1 2 chunks +85 lines, -11 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extension_process_bindings.js View 1 1 chunk +24 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/test/TabsAPI/1/tabs_api.html View 1 3 chunks +72 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rafaelw
more tab events
11 years, 9 months ago (2009-04-21 20:17:29 UTC) #1
Matt Perry
http://codereview.chromium.org/88053/diff/1/4 File chrome/browser/extensions/extension_browser_event_router.cc (right): http://codereview.chromium.org/88053/diff/1/4#newcode171 Line 171: GetRequestContext())->DispatchEventToRenderers(kOnTabMoved, json_args); Might be nice to add a ...
11 years, 9 months ago (2009-04-21 21:06:53 UTC) #2
Aaron Boodman
LGTM http://codereview.chromium.org/88053/diff/1/4 File chrome/browser/extensions/extension_browser_event_router.cc (right): http://codereview.chromium.org/88053/diff/1/4#newcode68 Line 68: // Tab is new, send tab-created event. ...
11 years, 9 months ago (2009-04-21 22:50:45 UTC) #3
rafaelw
http://codereview.chromium.org/88053/diff/1/4 File chrome/browser/extensions/extension_browser_event_router.cc (right): http://codereview.chromium.org/88053/diff/1/4#newcode68 Line 68: // Tab is new, send tab-created event. On ...
11 years, 9 months ago (2009-04-22 04:03:34 UTC) #4
Matt Perry
11 years, 9 months ago (2009-04-22 18:20:17 UTC) #5
lgtm

http://codereview.chromium.org/88053/diff/2001/2003
File chrome/browser/extensions/extension_browser_event_router.h (right):

http://codereview.chromium.org/88053/diff/2001/2003#newcode54
Line 54: // and tab insertion. Also used to not send tab-detached after
tab-removed.
nit: "Also used to avoid sending"

Powered by Google App Engine
This is Rietveld 408576698