Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5965)

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 88053: implement remaining tab events (except for onTabUpdated). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extension_process_bindings.js
===================================================================
--- chrome/renderer/resources/extension_process_bindings.js (revision 14176)
+++ chrome/renderer/resources/extension_process_bindings.js (working copy)
@@ -189,9 +189,31 @@
chromium.types.pInt
];
- // onTabMoved sends ({tabId, windowId, fromIndex, toIndex}) as named
- // arguments.
+ // sends ({tabId, windowId, index}).
+ // will *NOT* be followed by tab-attached - it is implied.
+ // *MAY* be followed by tab-selection-changed.
+ chromium.tabs.onTabCreated = new chromium.Event("tab-created");
+
+ // sends ({tabId, windowId, fromIndex, toIndex}).
+ // tabs can only "move" within a window.
chromium.tabs.onTabMoved = new chromium.Event("tab-moved");
+
+ // sends ({tabId, windowId, index}).
+ chromium.tabs.onTabSelectionChanged =
+ new chromium.Event("tab-selection-changed");
+
+ // sends ({tabId, windowId, index}).
+ // *MAY* be followed by tab-selection-changed.
+ chromium.tabs.onTabAttached = new chromium.Event("tab-attached");
+
+ // sends ({tabId, windowId, index}).
+ // *WILL* be followed by tab-selection-changed.
+ chromium.tabs.onTabDetached = new chromium.Event("tab-detached");
+
+ // sends (tabId).
+ // *WILL* be followed by tab-selection-changed.
+ // will *NOT* be followed or preceded by tab-detached.
+ chromium.tabs.onTabRemoved = new chromium.Event("tab-removed");
//----------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698