Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 880443004: Fix try-finally for dead AST-branches in TurboFan. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix try-finally for dead AST-branches in TurboFan. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-455644 BUG=chromium:455644 LOG=N Committed: https://crrev.com/df986d08b7c1a05dd72a8854ebed6f6338788c37 Cr-Commit-Position: refs/heads/master@{#26458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/control-builders.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/control-builders.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-455644.js View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-05 12:08:59 UTC) #1
Jarin
lgtm
5 years, 10 months ago (2015-02-05 12:13:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880443004/1
5 years, 10 months ago (2015-02-05 12:16:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 12:29:31 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 12:29:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df986d08b7c1a05dd72a8854ebed6f6338788c37
Cr-Commit-Position: refs/heads/master@{#26458}

Powered by Google App Engine
This is Rietveld 408576698