Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: src/compiler/control-builders.cc

Issue 880443004: Fix try-finally for dead AST-branches in TurboFan. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/control-builders.h ('k') | test/mjsunit/regress/regress-crbug-455644.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/control-builders.cc
diff --git a/src/compiler/control-builders.cc b/src/compiler/control-builders.cc
index 6dba2d3ad6083756aef4fbc1e43d392b9e85465b..2ace441e61eac82a83439ed2155a599128a290fb 100644
--- a/src/compiler/control-builders.cc
+++ b/src/compiler/control-builders.cc
@@ -151,7 +151,7 @@ void BlockBuilder::EndBlock() {
void TryCatchBuilder::BeginTry() {
catch_environment_ = environment()->CopyAsUnreachable();
- catch_environment_->Push(nullptr);
+ catch_environment_->Push(the_hole());
}
@@ -178,7 +178,7 @@ void TryCatchBuilder::EndCatch() {
void TryFinallyBuilder::BeginTry() {
finally_environment_ = environment()->CopyAsUnreachable();
- finally_environment_->Push(nullptr);
+ finally_environment_->Push(the_hole());
}
« no previous file with comments | « src/compiler/control-builders.h ('k') | test/mjsunit/regress/regress-crbug-455644.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698