chrome/BUILD.gn - Issue 880373008: Enable linking full chrome on windows GN builds again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 880373008: Enable linking full chrome on windows GN builds again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: re-add the PDF dependency but make it linux-only Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 6deb300898f0bbc30659dcd49b5c62c66bf71996..903ff5045fcc094784e2bdd88aa777b6327ffc79 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -51,8 +51,6 @@ if (!is_android && (!is_win || link_chrome_on_windows)) {

"app/chrome_watcher_command_line_win.h",

"app/client_util.cc",

"app/client_util.h",

- "app/chrome_watcher_command_line_win.cc",

- "app/chrome_watcher_command_line_win.h",

"app/signature_validator_win.cc",

"app/signature_validator_win.h",

"common/crash_keys.cc",

@@ -154,7 +152,7 @@ if (!is_android && (!is_win || link_chrome_on_windows)) {

# TODO(GYP) some stuff from GYP including chrome_multiple_dll.

}

- if (enable_plugins) {

+ if (is_linux && enable_plugins) {

brettw 2015/02/06 23:28:07 I don't understand this change.

deps += [ "//pdf" ]

}

« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »