build/config/BUILDCONFIG.gn - Issue 880373008: Enable linking full chrome on windows GN builds again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILDCONFIG.gn

Issue 880373008: Enable linking full chrome on windows GN builds again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: re-add the PDF dependency but make it linux-only Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/BUILDCONFIG.gn

diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn

index 33449ef780019ae8baedfba2dc4e95648f2e8e42..d806a1763a4e2cb35513d9834ace1dcc99c92ab7 100644

--- a/build/config/BUILDCONFIG.gn

+++ b/build/config/BUILDCONFIG.gn

@@ -80,7 +80,7 @@ declare_args() {

# TODO(brettw) remove this flag (and therefore enable linking all targets) on

# Windows when we have sufficient bot capacity. In the meantime, you can

# enable linking for local compiles.

- link_chrome_on_windows = false

+ link_chrome_on_windows = true

}

# =============================================================================

« no previous file with comments | « no previous file | chrome/BUILD.gn » ('j') | chrome/BUILD.gn » ('J')