Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 880343002: Cleanup GuestViewMessageFilter (Closed)

Created:
5 years, 10 months ago by Fady Samuel
Modified:
5 years, 10 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup GuestViewMessageFilter 1. Use auto to improve readability. 2. Rename methods to remove "Extension" prefix. 3. Use const where possible. 4. Use using content::* to improve readability. BUG=none Committed: https://crrev.com/90ba99132307524fb5ec891d11454e5f0e604847 Cr-Commit-Position: refs/heads/master@{#313608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -33 lines) Patch
M extensions/browser/guest_view/guest_view_message_filter.h View 3 chunks +10 lines, -10 lines 0 comments Download
M extensions/browser/guest_view/guest_view_message_filter.cc View 5 chunks +19 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
5 years, 10 months ago (2015-01-28 18:57:49 UTC) #2
lazyboy
lgtm
5 years, 10 months ago (2015-01-28 21:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880343002/1
5 years, 10 months ago (2015-01-28 21:43:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 23:15:15 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 23:16:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90ba99132307524fb5ec891d11454e5f0e604847
Cr-Commit-Position: refs/heads/master@{#313608}

Powered by Google App Engine
This is Rietveld 408576698