Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: extensions/browser/guest_view/guest_view_message_filter.h

Issue 880343002: Cleanup GuestViewMessageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/guest_view/guest_view_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/guest_view_message_filter.h
diff --git a/extensions/browser/guest_view/guest_view_message_filter.h b/extensions/browser/guest_view/guest_view_message_filter.h
index 9321973906992a95c068a76909acdeb0a941a0aa..593b6315e676dc4c2ffc960f1fa7ca1bf2b5494f 100644
--- a/extensions/browser/guest_view/guest_view_message_filter.h
+++ b/extensions/browser/guest_view/guest_view_message_filter.h
@@ -34,7 +34,7 @@ class GuestViewMessageFilter : public content::BrowserMessageFilter {
GuestViewMessageFilter(int render_process_id,
content::BrowserContext* context);
- int render_process_id() { return render_process_id_; }
+ int render_process_id() const { return render_process_id_; }
private:
friend class content::BrowserThread;
@@ -49,14 +49,14 @@ class GuestViewMessageFilter : public content::BrowserMessageFilter {
bool OnMessageReceived(const IPC::Message& message) override;
// Message handlers on the UI thread.
- void OnExtensionAttachGuest(int routing_id,
- int element_instance_id,
- int guest_instance_id,
- const base::DictionaryValue& attach_params);
- void OnExtensionCreateMimeHandlerViewGuest(int render_frame_id,
- const std::string& view_id,
- int element_instance_id,
- const gfx::Size& element_size);
+ void OnAttachGuest(int routing_id,
+ int element_instance_id,
+ int guest_instance_id,
+ const base::DictionaryValue& attach_params);
+ void OnCreateMimeHandlerViewGuest(int render_frame_id,
+ const std::string& view_id,
+ int element_instance_id,
+ const gfx::Size& element_size);
// Runs on UI thread.
void MimeHandlerViewGuestCreatedCallback(int element_instance_id,
@@ -68,7 +68,7 @@ class GuestViewMessageFilter : public content::BrowserMessageFilter {
const int render_process_id_;
// Should only be accessed on the UI thread.
- content::BrowserContext* browser_context_;
+ content::BrowserContext* const browser_context_;
// Weak pointers produced by this factory are bound to the IO thread.
base::WeakPtrFactory<GuestViewMessageFilter> weak_ptr_factory_;
« no previous file with comments | « no previous file | extensions/browser/guest_view/guest_view_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698