Issue 880333003: Load API accessor from descriptor instead of embedding it in handler.

Issue 880333003: Load API accessor from descriptor instead of embedding it in handler. (Closed)

Created:
5 years, 10 months ago by ulan

Modified:
5 years, 10 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Load API accessor from descriptor instead of embedding it in handler. BUG=v8:3629 LOG=N Committed: https://crrev.com/6ea31f7eee230228c9d34362360b8b9f08e79815 Cr-Commit-Position: refs/heads/master@{#26320}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -47 lines)			Patch
M	src/ic/arm/handler-compiler-arm.cc	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	src/ic/arm64/handler-compiler-arm64.cc	View	1 2	4 chunks	+7 lines, -6 lines	0 comments	Download
M	src/ic/handler-compiler.h	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	src/ic/handler-compiler.cc	View		2 chunks	+8 lines, -6 lines	0 comments	Download
M	src/ic/ia32/handler-compiler-ia32.cc	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	src/ic/ic.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/ic/mips/handler-compiler-mips.cc	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	src/ic/mips64/handler-compiler-mips64.cc	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	src/ic/x64/handler-compiler-x64.cc	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	src/ic/x87/handler-compiler-x87.cc	View		3 chunks	+7 lines, -5 lines	0 comments	Download

Total messages: 7 (2 generated)

ulan

PTAL. This is the first step in removing embedded pointers in ApiAccessorCall

5 years, 10 months ago (2015-01-28 18:17:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880333003/40001

5 years, 10 months ago (2015-01-29 09:36:16 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 09:58:22 UTC) #7

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/6ea31f7eee230228c9d34362360b8b9f08e79815
Cr-Commit-Position: refs/heads/master@{#26320}