Add RGB565 Texture readback support in gl_helper

content/browser/android/content_view_core_impl.h

Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index 7a3b449fe9f630109753e0371e746c72edb9a48b..fde07e684230b1fca3e5c222137e3704643e1415 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -308,6 +308,10 @@ class ContentViewCoreImpl : public ContentViewCore,
   void AddBeginFrameSubscriber();
   void RemoveBeginFrameSubscriber();
   void SetNeedsAnimate();
+  void PopulateBitmapAsync(gfx::Rect src_subrect,
+                           gfx::Size dst_size,
+                           bool readback_config_rgb565);

[no sievers, 2014/01/07 16:26:02]

Adding this here is unnecessary since ContentViewCoreImpl does not make the API
more public than RWHV. It'd have to be virtual and exposed in
content/public/browser/android/content_view_core.h also.

Maybe we can sort out how this should be exposed to the embedder in a separate
patch?

[sivag, 2014/01/09 14:51:50]

Removed.

+  bool IsReadBackConfig565();

[no sievers, 2014/01/07 16:26:02]

Same for this. It should be in the same place and exposed to the embedder as the
above.

Maybe the requested format should even be added as an argument to
CopyFromCompositingSurface().

[sivag, 2014/01/09 14:51:50]

Removed.Argument added to CopyFromCompositingSurface.

 
  private:
   class ContentViewUserData;
@@ -383,6 +387,8 @@ class ContentViewCoreImpl : public ContentViewCore,
 
   bool geolocation_needs_pause_;
 
+  bool bitmap_config_is_565_;
+
   DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
 };