Add RGB565 Texture readback support in gl_helper

content/browser/android/content_view_core_impl.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
 
 #include <vector>
 
 #include "base/android/jni_android.h"
@@ skipping 290 matching lines @@
   gfx::Size GetPhysicalBackingSize() const;
   gfx::Size GetViewportSizeDip() const;
   gfx::Size GetViewportSizeOffsetDip() const;
   float GetOverdrawBottomHeightDip() const;
 
   void AttachLayer(scoped_refptr<cc::Layer> layer);
   void RemoveLayer(scoped_refptr<cc::Layer> layer);
   void AddBeginFrameSubscriber();
   void RemoveBeginFrameSubscriber();
   void SetNeedsAnimate();
+  void PopulateBitmapAsync(gfx::Rect src_subrect,
+                           gfx::Size dst_size,
+                           bool readback_config_rgb565);

[no sievers, 2014/01/07 16:26:02]

Adding this here is unnecessary since ContentViewCoreImpl does not make the API
more public than RWHV. It'd have to be virtual and exposed in
content/public/browser/android/content_view_core.h also.

Maybe we can sort out how this should be exposed to the embedder in a separate
patch?

[sivag, 2014/01/09 14:51:50]

Removed.

+  bool IsReadBackConfig565();

[no sievers, 2014/01/07 16:26:02]

Same for this. It should be in the same place and exposed to the embedder as the
above.

Maybe the requested format should even be added as an argument to
CopyFromCompositingSurface().

[sivag, 2014/01/09 14:51:50]

Removed.Argument added to CopyFromCompositingSurface.

 
  private:
   class ContentViewUserData;
 
   friend class ContentViewUserData;
   virtual ~ContentViewCoreImpl();
 
   // NotificationObserver implementation.
   virtual void Observe(int type,
                        const NotificationSource& source,
@@ skipping 55 matching lines @@
 
   // The owning window that has a hold of main application activity.
   ui::WindowAndroid* window_android_;
 
   // The cache of device's current orientation set from Java side, this value
   // will be sent to Renderer once it is ready.
   int device_orientation_;
 
   bool geolocation_needs_pause_;
 
+  bool bitmap_config_is_565_;
+
   DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
 };
 
 bool RegisterContentViewCore(JNIEnv* env);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_