Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 880303004: [Clean up] Fix the comment for SiteIntance::CreateForURL (Closed)

Created:
5 years, 10 months ago by jinlong.zhai
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, ajwong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Clean up] Fix the comment for SiteIntance::CreateForURL In SiteIntance::CreateForURL there will certainly create a new SiteInstance and BrowsingIntance since in this new BrowsingIntance we will not find any existing SiteIntance. So BrowsingIntance will never be deleted even beyond the scope of the method. The original comments will make some confusion. BUG=11629 Committed: https://crrev.com/9f9a53536cd585291f4a63f8a789fa64612dc73a Cr-Commit-Position: refs/heads/master@{#315308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/site_instance_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
jinlong.zhai
Please help to look at the nits. Thanks
5 years, 10 months ago (2015-02-06 08:56:40 UTC) #2
Charlie Reis
It helps to do some digging through past revisions to understand this, but I think ...
5 years, 10 months ago (2015-02-06 19:09:34 UTC) #4
Charlie Reis
I updated the bug number of the CL to 11629 so that we can track ...
5 years, 10 months ago (2015-02-06 19:10:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880303004/1
5 years, 10 months ago (2015-02-06 19:14:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41060)
5 years, 10 months ago (2015-02-06 19:21:02 UTC) #11
Charlie Reis
Looks like you're not listed in the authors file: http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41060/steps/presubmit/logs/stdio ** Presubmit Warnings ** jinlong.zhai@samsung.com ...
5 years, 10 months ago (2015-02-06 19:36:39 UTC) #12
jinlong.zhai
Now I have listed in the authors file, since my first patch have been merged ...
5 years, 10 months ago (2015-02-09 03:07:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880303004/1
5 years, 10 months ago (2015-02-09 15:00:28 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 15:54:39 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 15:55:05 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f9a53536cd585291f4a63f8a789fa64612dc73a
Cr-Commit-Position: refs/heads/master@{#315308}

Powered by Google App Engine
This is Rietveld 408576698