Issue 115110: Fix memory leak in SiteInstance::CreateSiteInstanceForURL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115110: Fix memory leak in SiteInstance::CreateSiteInstanceForURL. (Closed)

Created:
11 years, 7 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix memory leak in SiteInstance::CreateSiteInstanceForURL. TBR=creis Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15596

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/tab_contents/site_instance.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

11 years, 7 months ago (2009-05-08 00:17:42 UTC) #2

Ah, good point.  LGTM.

(All of this reminds me that BrowsingInstances should eventually be refactored
so that the process decisions are independent of what SiteInstance and
BrowsingInstance a page belongs to.  It's strange for a SiteInstance belonging
to one BrowsingInstance to be returned by another one.  No worries for now,
though.)

Expand Messages | Collapse Messages