Networking.config: Implementation of the NetworkingConfigService

extensions/common/api/networking_config.idl

Index: extensions/common/api/networking_config.idl
diff --git a/chrome/common/extensions/api/networking_config.idl b/extensions/common/api/networking_config.idl
similarity index 81%
rename from chrome/common/extensions/api/networking_config.idl
rename to extensions/common/api/networking_config.idl
index ea4c4321b76495e927efe4ec5e57d2cc3a2a6bd2..eed427fee8689cc1b51b0fe3fc44bb9be31fb9bc 100644
--- a/chrome/common/extensions/api/networking_config.idl
+++ b/extensions/common/api/networking_config.idl
@@ -4,6 +4,8 @@
 
 // Use the <code>networking.config</code> API to authenticate to captive
 // portals.
+[implemented_in =
+"extensions/browser/api/networking_config/networking_config_api.h"]

[not at google - send to devlin, 2015/01/29 16:48:38]

Is this needed when the API is already in /extensions?

If so it's worth filing a bug about.

[cschuet (SLOW), 2015/01/30 12:33:34]

Done.

 namespace networking.config {
   // Indicator for the type of network used in $(NetworkInfo).
   enum NetworkType { WiFi };
@@ -49,6 +51,13 @@ namespace networking.config {
     failed
   };
 
+  // Invoked by $(setNetworkFilter) when the respective operation is finished.
+  callback SetNetworkFilterCallback = void();
+
+  // Invoked by $(finishAuthentication) when the respective operation is
+  // finished.
+  callback FinishAuthenticationCallback = void();
+
   interface Functions {
     // Allows an extension to define network filters for the networks it can
     // handle. A call to this function will remove all filters previously
@@ -56,16 +65,20 @@ namespace networking.config {
     // |networks|: Network filters to set. Every <code>NetworkInfo</code> must
     //             either have the <code>SSID</code> or <code>HexSSID</code>
     //             set. Other fields will be ignored.
-    void setNetworkFilter(NetworkInfo[] networks);
+    // |callback|: Called back when this operation is finished.
+    void setNetworkFilter(NetworkInfo[] networks,
+                          SetNetworkFilterCallback callback);
 
     // Called by the extension to notify the network config API that it finished
     // a captive portal authentication attempt and hand over the result of the
     // attempt. This function must only be called with the GUID of the latest
     // $(onCaptivePortalDetected) event.
-    // |GUID|: unique network identifier obtained from
+    // |GUID|: Unique network identifier obtained from
     //         $(onCaptivePortalDetected).
-    // |result|: the result of the authentication attempt
-    void finishAuthentication(DOMString GUID, AuthenticationResult result);
+    // |result|: The result of the authentication attempt.
+    // |callback|: Called back when this operation is finished.
+    void finishAuthentication(DOMString GUID, AuthenticationResult result,
+                              FinishAuthenticationCallback callback);
   };
 
   interface Events {