Networking.config: Implementation of the NetworkingConfigService

extensions/common/api/networking_config.idl

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>networking.config</code> API to authenticate to captive
 // portals.
+[implemented_in =
+"extensions/browser/api/networking_config/networking_config_api.h"]

[not at google - send to devlin, 2015/01/29 16:48:38]

Is this needed when the API is already in /extensions?

If so it's worth filing a bug about.

[cschuet (SLOW), 2015/01/30 12:33:34]

Done.

 namespace networking.config {
   // Indicator for the type of network used in $(NetworkInfo).
   enum NetworkType { WiFi };
 
   // A dictionary identifying filtered networks. One of <code>GUID</code>,
   // <code>SSID</code> or <code>HexSSID</code> must be set.
   dictionary NetworkInfo {
     // Currently only WiFi supported, see $(NetworkType).
     NetworkType Type;
 
@@ skipping 25 matching lines @@
 
     // The extension handled this network, tried to authenticate, however was
     // rejected by the server.
     rejected,
 
     // The extension handled this network, tried to authenticate, however failed
     // due to an unspecified error.
     failed
   };
 
+  // Invoked by $(setNetworkFilter) when the respective operation is finished.
+  callback SetNetworkFilterCallback = void();
+
+  // Invoked by $(finishAuthentication) when the respective operation is
+  // finished.
+  callback FinishAuthenticationCallback = void();
+
   interface Functions {
     // Allows an extension to define network filters for the networks it can
     // handle. A call to this function will remove all filters previously
     // installed by the extension before setting the new list.
     // |networks|: Network filters to set. Every <code>NetworkInfo</code> must
     //             either have the <code>SSID</code> or <code>HexSSID</code>
     //             set. Other fields will be ignored.
-    void setNetworkFilter(NetworkInfo[] networks);
+    // |callback|: Called back when this operation is finished.
+    void setNetworkFilter(NetworkInfo[] networks,
+                          SetNetworkFilterCallback callback);
 
     // Called by the extension to notify the network config API that it finished
     // a captive portal authentication attempt and hand over the result of the
     // attempt. This function must only be called with the GUID of the latest
     // $(onCaptivePortalDetected) event.
-    // |GUID|: unique network identifier obtained from
+    // |GUID|: Unique network identifier obtained from
     //         $(onCaptivePortalDetected).
-    // |result|: the result of the authentication attempt
-    void finishAuthentication(DOMString GUID, AuthenticationResult result);
+    // |result|: The result of the authentication attempt.
+    // |callback|: Called back when this operation is finished.
+    void finishAuthentication(DOMString GUID, AuthenticationResult result,
+                              FinishAuthenticationCallback callback);
   };
 
   interface Events {
     // This event fires everytime a captive portal is detected on a network
     // matching any of the currently registered network filters and the user
     // consents to use the extension for authentication. Network filters may be
     // set using the $(setNetworkFilter).
     // Upon receiving this event the extension should start its authentication
     // attempt with the captive portal. When the extension finishes its attempt
     // it must call $(finishAuthentication) with the <code>GUID</code> received
     // with this event and the appropriate $(AuthenticationResult) to notify
     // the captive portal API.
     // |networkInfo|: information about the network on which a captive portal
     // was detected.
     static void onCaptivePortalDetected(NetworkInfo networkInfo);
   };
 };