Networking.config: Implementation of the NetworkingConfigService

Networking.config: Implementation of the NetworkingConfigService

Implementation of the NetworkingConfigService and boiler plate code for the
networking.config API.

Reviewers:
Please see
1) https://docs.google.com/document/d/1V8YGouKC477iC11L4PL8H_HU1Ru3R5kMhXppuoIVNeo for the design document.
2) https://docs.google.com/drawings/d/12Hai1LdaPzwtkrQUdCjSpt1s7InRNNBDeWiW5ujfIRg for a flow diagram.

Committed: https://crrev.com/b34ff556a7902fe52fe17e63c2e05faa616c8380
Cr-Commit-Position: refs/heads/master@{#314303}

[cschuet (SLOW), 2015-01-27 20:14:56]

cschuet@chromium.org changed reviewers:
+ pneubeck@chromium.org

[cschuet (SLOW), 2015-01-27 20:18:58]

cschuet@chromium.org changed reviewers:
+ stevenjb@chromium.org

[cschuet (SLOW), 2015-01-27 20:24:43]

cschuet@chromium.org changed reviewers:
+ asargent@chromium.org, asvitkine@chromium.org, mkwst@chromium.org

[cschuet (SLOW), 2015-01-27 20:24:44]

asvitkine@chromium.org: Please review changes in
extensions/browser/extension_function_histogram_value.h

mkwst@chromium.org: Please review changes in 
chrome/common/extensions/*

asargent@chromium.org: Please review changes in 
chrome/browser/extensions/*

[cschuet (SLOW), 2015-01-27 20:28:37]

asvitkine@chromium.org: Please review changes in
extensions/browser/extension_function_histogram_value.h

mkwst@chromium.org: Please review changes in 
chrome/common/extensions/*

asargent@chromium.org: Please review changes in 
chrome/browser/extensions/*

[stevenjb, 2015-01-27 21:01:50]

I haven't done a full review, but I would like to suggest placing this in
src/extensions instead of src/chrome unless there is any strong reason why we
can't.

That would make the API available to AppShell and other non-chrome executables
in the future (as well as improve code modularization).

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/networking_config/networking_config_api.cc
(right):

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.cc:12:
#include "chrome/browser/profiles/profile.h"
We can probably use BrowserContext instead

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/networking_config/networking_config_api.h
(right):

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:8:
#include "chrome/browser/extensions/chrome_extension_function.h"
Does this need to be in src/chrome, or can we put it in src/extensions/browser?

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:16:
NetworkingConfigSetNetworkFilterFunction();
WS

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:24:
parameters_;
members after methods

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:25:
~NetworkingConfigSetNetworkFilterFunction() override;
DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:31:
NetworkingConfigFinishAuthenticationFunction();
WS

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:39:
parameters_;
After methods

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:40:
~NetworkingConfigFinishAuthenticationFunction() override;
DISALLOW_COPY_AND_ASSIGN

[Mike West, 2015-01-29 11:55:04]

I'm only in the extensions OWNERS file for documentation changes. I'd suggest
poking at asargent@ or kalman@.

[Mike West, 2015-01-29 11:55:13]

mkwst@chromium.org changed reviewers:
+ kalman@chromium.org

[cschuet (SLOW), 2015-01-29 13:07:35]

cschuet@chromium.org changed reviewers:
- mkwst@chromium.org

[cschuet (SLOW), 2015-01-29 13:24:28]

cschuet@chromium.org changed reviewers:
- asargent@chromium.org, asvitkine@chromium.org, kalman@chromium.org,
pneubeck@chromium.org, stevenjb@chromium.org

[cschuet (SLOW), 2015-01-29 13:25:19]

cschuet@chromium.org changed reviewers:
+ pneubeck@chromium.org, stevenjb@chromium.org

[cschuet (SLOW), 2015-01-29 13:25:20]

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/networking_config/networking_config_api.h
(right):

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:16:
NetworkingConfigSetNetworkFilterFunction();
On 2015/01/27 21:01:50, stevenjb wrote:
> WS

Done.

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:24:
parameters_;
On 2015/01/27 21:01:49, stevenjb wrote:
> members after methods

Done.

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:25:
~NetworkingConfigSetNetworkFilterFunction() override;
On 2015/01/27 21:01:50, stevenjb wrote:
> DISALLOW_COPY_AND_ASSIGN

Done.

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:31:
NetworkingConfigFinishAuthenticationFunction();
On 2015/01/27 21:01:50, stevenjb wrote:
> WS

Done.

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:39:
parameters_;
On 2015/01/27 21:01:50, stevenjb wrote:
> After methods

Done.

https://codereview.chromium.org/880073002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_config/networking_config_api.h:40:
~NetworkingConfigFinishAuthenticationFunction() override;
On 2015/01/27 21:01:50, stevenjb wrote:
> DISALLOW_COPY_AND_ASSIGN

Done.

[cschuet (SLOW), 2015-01-29 13:28:26]

cschuet@chromium.org changed reviewers:
+ asargent@chromium.org, asvitkine@chromium.org

[cschuet (SLOW), 2015-01-29 13:28:27]

asvitkine@chromium.org: Please review changes in 
extensions/browser/extension_function_histogram_value.h

asargent@chromium.org: Please review changes in 
chrome/common/extensions/*
extensions/*

[not at google - send to devlin, 2015-01-29 16:48:37]

kalman@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2015-01-29 16:48:38]

Some nits, but could you point me at the place where this authentication stuff
is attributed to the extension which sets it?

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
File extensions/browser/api/networking_config/networking_config_api.cc (right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.cc:23: "(hex): ";
Idiomatic: make this "(hex): *" and below use
Error(kMalformedFilterDescriptionWithSSID, hex_ssid).

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.cc:41:
std::string id = extension_id();
This creates an unnecessary copy. extension_id() return a const&. Alias is low
value anyway since it's only used in 2 places, but up to you.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.cc:102:
NOTREACHED();
It'd still be good to populate authentication_result.authentication_state. I
would suggest on initialization, you could be neat and do like

NetworkingConfigService::AuthenticationResult authentication_result = {
  extension_id(),
  parameters_->guid,
  NetworkingConfigService::FAILED,
};

if you like.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.cc:121:
networkingConfigService->SetAuthenticationResult(authentication_result);
|networking_config_service|? or just |service|, whatever, so long as it's
style-guidey.

https://codereview.chromium.org/880073002/diff/120001/extensions/common/api/n...
File extensions/common/api/networking_config.idl (right):

https://codereview.chromium.org/880073002/diff/120001/extensions/common/api/n...
extensions/common/api/networking_config.idl:8:
"extensions/browser/api/networking_config/networking_config_api.h"]
Is this needed when the API is already in /extensions?

If so it's worth filing a bug about.

[Alexei Svitkine (slow), 2015-01-29 16:53:03]

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/exte...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/exte...
extensions/browser/extension_function_histogram_value.h:1018: //
tools/metrics/histograms/histograms.xml.
Please update histograms.xml.

[stevenjb, 2015-01-29 17:51:35]

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
File extensions/browser/api/networking_config/networking_config_api.cc (right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.cc:50: return
RespondNow(Error(kMalformedFilterDescription));
nit: Maybe include an "Unsupported network type" error?

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
File extensions/browser/api/networking_config/networking_config_api.h (right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.h:6: #define
CHROME_BROWSER_EXTENSIONS_API_NETWORKING_CONFIG_NETWORKING_CONFIG_API_H_
Update guards

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
File extensions/browser/api/networking_config/networking_config_service.h
(right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:6: #define
CHROME_BROWSER_EXTENSIONS_API_NETWORKING_CONFIG_NETWORKING_CONFIG_SERVICE_H_
Fix all header guards.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:19: 
Brief comment describing the purpose of this class. Also, it's not clear from
the class name + description whether this is intended to implement the entire
networking_config API, or just the captive portal authentication portion. We
should make that clear.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:42:
AuthenticationState authentication_state;
optional nit: We can now use:
authentication_state = NetworkingConfigService::NOTRY;
in the declaration. See Non-Static Class Member Initializers in
http://chromium-cpp.appspot.com/

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:47:
ExtensionRegistry* extension_registry);
no explicit

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:58:
std::string GetExtensionIdForHexSsid(std::string hex_ssid) const;
nit: Is this the primary way we are going to determine whether or not a network
has an associated extension? If so we might want to name this 'Find' or 'Lookup.
'Get' kind of implies that it is expected or at least likely that the thing
being gotten exists.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:70: bool
RegisterHexSsid(std::string hex_ssid, const std::string& extension_id);
Are the above two methods going to be limited to captive portal events? If so,
we should rename the methods, if not we should update the comments to just refer
to 'events'.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
File
extensions/browser/api/networking_config/networking_config_service_factory.cc
(right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service_factory.cc:23:
~DefaultEventDelegate() override;
WS

[cschuet (SLOW), 2015-01-30 12:33:34]

@kalman - concerning the authentication result:

After an authentication attempt the extension sets the AuthenticationResult
using the extension API function FinishAuthentication. As part of its
implementation (line 97 of networking_config_api.cc) it sets the extension_id
field by calling extension_id() which returns the id of the calling extension.
The current AuthenticationResult is therefore always correctly associated with
the extension that set it.

Visual attribution for the user is achieve by mentioning the name of the
extension that will be invoked (and hence given a chance to set the
AuthenticationResult later) in the popup asking the user for consent to allow
the extension to attempt a captive portal authentication. This code will be
submitted as a subsequent CL.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
File extensions/browser/api/networking_config/networking_config_api.cc (right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.cc:23: "(hex): ";
On 2015/01/29 16:48:38, kalman wrote:
> Idiomatic: make this "(hex): *" and below use
> Error(kMalformedFilterDescriptionWithSSID, hex_ssid).

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.cc:41:
std::string id = extension_id();
On 2015/01/29 16:48:38, kalman wrote:
> This creates an unnecessary copy. extension_id() return a const&. Alias is low
> value anyway since it's only used in 2 places, but up to you.

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.cc:50: return
RespondNow(Error(kMalformedFilterDescription));
On 2015/01/29 17:51:35, stevenjb wrote:
> nit: Maybe include an "Unsupported network type" error?

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.cc:102:
NOTREACHED();
On 2015/01/29 16:48:38, kalman wrote:
> It'd still be good to populate authentication_result.authentication_state. I
> would suggest on initialization, you could be neat and do like
> 
> NetworkingConfigService::AuthenticationResult authentication_result = {
>   extension_id(),
>   parameters_->guid,
>   NetworkingConfigService::FAILED,
> };
> 
> if you like.

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.cc:121:
networkingConfigService->SetAuthenticationResult(authentication_result);
On 2015/01/29 16:48:38, kalman wrote:
> |networking_config_service|? or just |service|, whatever, so long as it's
> style-guidey.

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
File extensions/browser/api/networking_config/networking_config_api.h (right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_api.h:6: #define
CHROME_BROWSER_EXTENSIONS_API_NETWORKING_CONFIG_NETWORKING_CONFIG_API_H_
On 2015/01/29 17:51:35, stevenjb wrote:
> Update guards

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
File extensions/browser/api/networking_config/networking_config_service.h
(right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:6: #define
CHROME_BROWSER_EXTENSIONS_API_NETWORKING_CONFIG_NETWORKING_CONFIG_SERVICE_H_
On 2015/01/29 17:51:35, stevenjb wrote:
> Fix all header guards.

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:19: 
On 2015/01/29 17:51:35, stevenjb wrote:
> Brief comment describing the purpose of this class. Also, it's not clear from
> the class name + description whether this is intended to implement the entire
> networking_config API, or just the captive portal authentication portion. We
> should make that clear.
> 

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:42:
AuthenticationState authentication_state;
On 2015/01/29 17:51:35, stevenjb wrote:
> optional nit: We can now use:
> authentication_state = NetworkingConfigService::NOTRY;
> in the declaration. See Non-Static Class Member Initializers in
> http://chromium-cpp.appspot.com/
> 

Acknowledged.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:47:
ExtensionRegistry* extension_registry);
On 2015/01/29 17:51:35, stevenjb wrote:
> no explicit

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:58:
std::string GetExtensionIdForHexSsid(std::string hex_ssid) const;
On 2015/01/29 17:51:35, stevenjb wrote:
> nit: Is this the primary way we are going to determine whether or not a
network
> has an associated extension? If so we might want to name this 'Find' or
'Lookup.
> 'Get' kind of implies that it is expected or at least likely that the thing
> being gotten exists.

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service.h:70: bool
RegisterHexSsid(std::string hex_ssid, const std::string& extension_id);
On 2015/01/29 17:51:35, stevenjb wrote:
> Are the above two methods going to be limited to captive portal events? If so,
> we should rename the methods, if not we should update the comments to just
refer
> to 'events'.

I think that IsRegisteredForCaptivePortalEvent should be a captive portal
specific method, while RegisterHexSsid registers an SSID for a network in
general. In the future, when we implement more of the networking config
functionality, we will have to make the signature of this function richer to
give the extension the possibility to specify which events it is interested in.
Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
File
extensions/browser/api/networking_config/networking_config_service_factory.cc
(right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/api/...
extensions/browser/api/networking_config/networking_config_service_factory.cc:23:
~DefaultEventDelegate() override;
On 2015/01/29 17:51:35, stevenjb wrote:
> WS

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/exte...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/880073002/diff/120001/extensions/browser/exte...
extensions/browser/extension_function_histogram_value.h:1018: //
tools/metrics/histograms/histograms.xml.
On 2015/01/29 16:53:03, Alexei Svitkine wrote:
> Please update histograms.xml.

Done.

https://codereview.chromium.org/880073002/diff/120001/extensions/common/api/n...
File extensions/common/api/networking_config.idl (right):

https://codereview.chromium.org/880073002/diff/120001/extensions/common/api/n...
extensions/common/api/networking_config.idl:8:
"extensions/browser/api/networking_config/networking_config_api.h"]
On 2015/01/29 16:48:38, kalman wrote:
> Is this needed when the API is already in /extensions?
> 
> If so it's worth filing a bug about.

Done.

[stevenjb, 2015-01-30 17:27:26]

extensions/browser/api/networking_config/ lgtm

[cschuet (SLOW), 2015-02-01 18:24:51]

@asvitkine ptal
@asargent friendly review ping :)

[Alexei Svitkine (slow), 2015-02-02 15:05:56]

lgtm

[asargent_no_longer_on_chrome, 2015-02-02 18:01:14]

Are there any files in here where I'm an OWNER and kalman is not? If not then
just get his ok and you should be set extensions-wise.

[cschuet (SLOW), 2015-02-02 18:06:52]

cschuet@chromium.org changed reviewers:
- asargent@chromium.org

[cschuet (SLOW), 2015-02-02 18:08:39]

@kalman: Would you take a look at the files extensions/*  and see if you are
happy with the implementation?

[not at google - send to devlin, 2015-02-02 18:16:09]

lgtm for mechanical move changes, I don't have to look at anything else right?

https://codereview.chromium.org/880073002/diff/140001/extensions/browser/brow...
File extensions/browser/browser_context_keyed_service_factories.cc (right):

https://codereview.chromium.org/880073002/diff/140001/extensions/browser/brow...
extensions/browser/browser_context_keyed_service_factories.cc:50:
NetworkingConfigServiceFactory::GetInstance();
rockot/yoz/reillyg - I just had this thought - why do we eagerly create all of
these? We know what APIs Extensions use, which is almost certainly not going to
be *all* of them, so it would be better to lazily create them?

[pneubeck (no reviews), 2015-02-02 18:18:33]

https://codereview.chromium.org/880073002/diff/140001/extensions/browser/brow...
File extensions/browser/browser_context_keyed_service_factories.cc (right):

https://codereview.chromium.org/880073002/diff/140001/extensions/browser/brow...
extensions/browser/browser_context_keyed_service_factories.cc:50:
NetworkingConfigServiceFactory::GetInstance();
On 2015/02/02 18:16:09, kalman wrote:
> rockot/yoz/reillyg - I just had this thought - why do we eagerly create all of
> these? We know what APIs Extensions use, which is almost certainly not going
to
> be *all* of them, so it would be better to lazily create them?

KeyedService factories _must_ be created before the dependency manager is
started, so that they can register their dependencies.

The Services themselves can be created lazily by the factory.

[not at google - send to devlin, 2015-02-02 18:33:17]

https://codereview.chromium.org/880073002/diff/140001/extensions/browser/brow...
File extensions/browser/browser_context_keyed_service_factories.cc (right):

https://codereview.chromium.org/880073002/diff/140001/extensions/browser/brow...
extensions/browser/browser_context_keyed_service_factories.cc:50:
NetworkingConfigServiceFactory::GetInstance();
On 2015/02/02 18:18:33, pneubeck wrote:
> On 2015/02/02 18:16:09, kalman wrote:
> > rockot/yoz/reillyg - I just had this thought - why do we eagerly create all
of
> > these? We know what APIs Extensions use, which is almost certainly not going
> to
> > be *all* of them, so it would be better to lazily create them?
> 
> KeyedService factories _must_ be created before the dependency manager is
> started, so that they can register their dependencies.
> 
> The Services themselves can be created lazily by the factory.

Ah right, this is just registering dependencies. Presumably that means that we
don't create the actual APIs if they're not used.

[cschuet (SLOW), 2015-02-02 18:35:33]

The CQ bit was checked by cschuet@chromium.org

[commit-bot: I haz the power, 2015-02-02 18:36:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880073002/140001

[commit-bot: I haz the power, 2015-02-02 18:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-02 18:59:21]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cschuet (SLOW), 2015-02-02 19:44:03]

The CQ bit was checked by cschuet@chromium.org

[commit-bot: I haz the power, 2015-02-02 19:44:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880073002/180001

[cschuet (SLOW), 2015-02-02 20:36:16]

The CQ bit was checked by cschuet@chromium.org

[commit-bot: I haz the power, 2015-02-02 20:37:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880073002/220001

[cschuet (SLOW), 2015-02-02 20:47:26]

The CQ bit was unchecked by cschuet@chromium.org

[cschuet (SLOW), 2015-02-02 20:50:37]

The CQ bit was checked by cschuet@chromium.org

[commit-bot: I haz the power, 2015-02-02 20:51:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880073002/240001

[commit-bot: I haz the power, 2015-02-02 21:44:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-02 21:44:13]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cschuet (SLOW), 2015-02-03 09:02:04]

The CQ bit was checked by cschuet@chromium.org

[commit-bot: I haz the power, 2015-02-03 09:02:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880073002/280001

[commit-bot: I haz the power, 2015-02-03 10:24:17]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2015-02-03 10:25:07]

Patchset 15 (id:??) landed as
https://crrev.com/b34ff556a7902fe52fe17e63c2e05faa616c8380
Cr-Commit-Position: refs/heads/master@{#314303}

[pneubeck (no reviews), 2015-02-10 08:55:58]

please set BUG= in the commit message in the future.