Remove obsolete sandbox disabling logic from testing/test_env.py.

Remove obsolete sandbox disabling logic from testing/test_env.py.

This mirrors the change made to build/runtest.py in
https://codereview.chromium.org/881743004

BUG=245376
R=stip@chromium.org, jln@chromium.org
TBR=mseaborn@chromium.org
NOTRY=true

Committed: https://crrev.com/748e135c3a799a9a51cdbb1d8a8955c36569db02
Cr-Commit-Position: refs/heads/master@{#313392}

[earthdok, 2015-01-27 20:10:23]

earthdok@chromium.org changed reviewers:
+ jln@chromium.org

[earthdok, 2015-01-27 20:10:41]

+jln@

[jln (very slow on Chromium), 2015-01-27 20:19:48]

Thanks again for taking care of this!

https://codereview.chromium.org/880053003/diff/1/testing/test_env.py
File testing/test_env.py (right):

https://codereview.chromium.org/880053003/diff/1/testing/test_env.py#newcode21
testing/test_env.py:21: """Checks enables the sandbox if it is required,
otherwise it disables it.
This comment doesn't seem to match what we wish to do.

https://codereview.chromium.org/880053003/diff/1/testing/test_env.py#newcode24
testing/test_env.py:24: chrome_sandbox_path = env.get(CHROME_SANDBOX_ENV,
CHROME_SANDBOX_PATH)
Could you add a check that CHROME_SANDBOX_ENV is not the "" string ?

If it were the "" string, chrome_sandbox_path would be set to "" and the sandbox
would be silently disabled.

[earthdok, 2015-01-27 20:44:44]

https://codereview.chromium.org/880053003/diff/1/testing/test_env.py
File testing/test_env.py (right):

https://codereview.chromium.org/880053003/diff/1/testing/test_env.py#newcode21
testing/test_env.py:21: """Checks enables the sandbox if it is required,
otherwise it disables it.
On 2015/01/27 20:19:48, jln wrote:
> This comment doesn't seem to match what we wish to do.

Done.

https://codereview.chromium.org/880053003/diff/1/testing/test_env.py#newcode24
testing/test_env.py:24: chrome_sandbox_path = env.get(CHROME_SANDBOX_ENV,
CHROME_SANDBOX_PATH)
On 2015/01/27 20:19:48, jln wrote:
> Could you add a check that CHROME_SANDBOX_ENV is not the "" string ?
> 
> If it were the "" string, chrome_sandbox_path would be set to "" and the
sandbox
> would be silently disabled.

Done.

[jln (very slow on Chromium), 2015-01-27 21:04:05]

lgtm, thanks

[ghost stip (do not use), 2015-01-27 21:54:38]

lgtm

[earthdok, 2015-01-27 23:00:35]

earthdok@chromium.org changed reviewers:
+ mseaborn@chromium.org

[earthdok, 2015-01-27 23:00:49]

+Mark for nacl

[earthdok, 2015-01-27 23:00:56]

The CQ bit was checked by earthdok@chromium.org

[earthdok, 2015-01-27 23:01:44]

The CQ bit was unchecked by earthdok@chromium.org

[earthdok, 2015-01-27 23:01:59]

The CQ bit was checked by earthdok@chromium.org

[earthdok, 2015-01-27 23:02:35]

The CQ bit was unchecked by earthdok@chromium.org

[earthdok, 2015-01-27 23:02:35]

The CQ bit was checked by earthdok@chromium.org

[commit-bot: I haz the power, 2015-01-27 23:03:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880053003/40001

[commit-bot: I haz the power, 2015-01-27 23:04:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-27 23:06:58]

Patchset 3 (id:??) landed as
https://crrev.com/748e135c3a799a9a51cdbb1d8a8955c36569db02
Cr-Commit-Position: refs/heads/master@{#313392}

[Mark Seaborn, 2015-01-28 21:39:25]

Rubber stamp LGTM for NaCl