DescriptionRemove obsolete sandbox disabling logic from runtest.py.
Previously, we disabled the SUID sandbox by setting CHROME_DEVEL_SANDBOX="" in
the following cases:
- If LSan or TSan were enabled. However, we already pass --no-sandbox in this
case, so setting the env variable to an empty string is unnecessary.
- If the SUID sandbox binary was not present or not configured correctly.
This was useful when SUID sandbox was being rolled out. However, according to
https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment
the sandbox binary must now be present on all bots. If it isn't, it makes more
sense to fail than to disable the sandbox. Also, according to the same doc,
setting the env variable to "" is no longer a supported way of disabling the
sandbox.
BUG=245376
R=stip@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293832
Patch Set 1 #Patch Set 2 : s/should/must/ #Messages
Total messages: 6 (1 generated)
|