Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 881743004: Remove obsolete sandbox disabling logic from runtest.py. (Closed)

Created:
5 years, 11 months ago by earthdok
Modified:
5 years, 11 months ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Remove obsolete sandbox disabling logic from runtest.py. Previously, we disabled the SUID sandbox by setting CHROME_DEVEL_SANDBOX="" in the following cases: - If LSan or TSan were enabled. However, we already pass --no-sandbox in this case, so setting the env variable to an empty string is unnecessary. - If the SUID sandbox binary was not present or not configured correctly. This was useful when SUID sandbox was being rolled out. However, according to https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment the sandbox binary must now be present on all bots. If it isn't, it makes more sense to fail than to disable the sandbox. Also, according to the same doc, setting the env variable to "" is no longer a supported way of disabling the sandbox. BUG=245376 R=stip@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293832

Patch Set 1 #

Patch Set 2 : s/should/must/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -35 lines) Patch
M scripts/slave/runtest.py View 1 2 chunks +2 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
earthdok
Mike, please take a look. +jln@ FYI The same change will need to be done ...
5 years, 11 months ago (2015-01-27 19:45:55 UTC) #1
jln (very slow on Chromium)
Thanks a lot for doing that! lgtm on my side You may want to link ...
5 years, 11 months ago (2015-01-27 20:08:38 UTC) #2
ghost stip (do not use)
owner lgtm
5 years, 11 months ago (2015-01-27 21:49:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881743004/20001
5 years, 11 months ago (2015-01-27 23:01:55 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 23:04:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293832

Powered by Google App Engine
This is Rietveld 408576698