Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 880023003: Do not override CHROME_DEVEL_SANDBOX in tools/valgrind/valgrind_test.py (Closed)

Created:
5 years, 11 months ago by earthdok
Modified:
5 years, 10 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not override CHROME_DEVEL_SANDBOX in tools/valgrind/valgrind_test.py Setting that variable to an empty string is not a supported way of disabling the sandbox. tools/valgrind/chrome_tests.py is supposed to pass "--no-sandbox" which takes care of that. BUG=245376 TBR=jln@chromium.org, timurrrr@chromium.org NOTRY=true Committed: https://crrev.com/65f9d720f95b3c6f8465ad2fe7d49ac098b51a31 Cr-Commit-Position: refs/heads/master@{#313517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/valgrind/valgrind_test.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
earthdok
found another instance while I was at it
5 years, 11 months ago (2015-01-27 20:21:51 UTC) #1
jln (very slow on Chromium)
lgtm
5 years, 11 months ago (2015-01-28 01:57:44 UTC) #2
Alexander Potapenko
LGTM
5 years, 11 months ago (2015-01-28 11:14:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880023003/1
5 years, 10 months ago (2015-01-28 15:33:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 15:34:22 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 15:36:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65f9d720f95b3c6f8465ad2fe7d49ac098b51a31
Cr-Commit-Position: refs/heads/master@{#313517}

Powered by Google App Engine
This is Rietveld 408576698