tools/valgrind/valgrind_test.py - Issue 880023003: Do not override CHROME_DEVEL_SANDBOX in tools/valgrind/valgrind_test.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/valgrind/valgrind_test.py

Issue 880023003: Do not override CHROME_DEVEL_SANDBOX in tools/valgrind/valgrind_test.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/valgrind/valgrind_test.py

diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py

index 5576ed3177655d43038fc6e24609227e95610000..6efaeb610915e3fef140f4146b9c1ce85edac573 100644

--- a/tools/valgrind/valgrind_test.py

+++ b/tools/valgrind/valgrind_test.py

@@ -380,12 +380,6 @@ class ValgrindTool(BaseTool):

# The Valgrind command is constructed.

- # Valgrind doesn't play nice with the Chrome sandbox. Empty this env var

- # set by runtest.py to disable the sandbox.

- if os.environ.get("CHROME_DEVEL_SANDBOX", None):

- logging.info("Removing CHROME_DEVEL_SANDBOX from environment")

- os.environ["CHROME_DEVEL_SANDBOX"] = ''

# Handle --indirect_webkit_layout separately.

if self._options.indirect_webkit_layout:

# Need to create the wrapper before modifying |proc|.

« no previous file with comments | « no previous file | no next file » | no next file with comments »