Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Unified Diff: Source/core/page/ChromeClient.h

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/Chrome.cpp ('k') | Source/core/page/CreateWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/ChromeClient.h
diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h
index 158f7c27cba57dba9e59d5e70286517b371af89d..75d2c847ad44f44e9a82b5acf4c46f0acada7421 100644
--- a/Source/core/page/ChromeClient.h
+++ b/Source/core/page/ChromeClient.h
@@ -48,7 +48,6 @@ class DateTimeChooser;
class DateTimeChooserClient;
class Element;
class FileChooser;
-class FloatRect;
class Frame;
class GraphicsContext;
class GraphicsLayer;
@@ -74,10 +73,10 @@ class ChromeClient {
public:
virtual void chromeDestroyed() = 0;
- virtual void setWindowRect(const FloatRect&) = 0;
- virtual FloatRect windowRect() = 0;
+ virtual void setWindowRect(const IntRect&) = 0;
+ virtual IntRect windowRect() = 0;
- virtual FloatRect pageRect() = 0;
+ virtual IntRect pageRect() = 0;
virtual void focus() = 0;
@@ -214,7 +213,7 @@ public:
virtual bool requestPointerLock() { return false; }
virtual void requestPointerUnlock() { }
- virtual FloatSize minimumWindowSize() const { return FloatSize(100, 100); }
+ virtual IntSize minimumWindowSize() const { return IntSize(100, 100); }
virtual bool isChromeClientImpl() const { return false; }
« no previous file with comments | « Source/core/page/Chrome.cpp ('k') | Source/core/page/CreateWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698