Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: Source/core/page/ChromeClient.h

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/page/Chrome.cpp ('k') | Source/core/page/CreateWindow.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 30 matching lines...) Expand all
41 41
42 namespace blink { 42 namespace blink {
43 43
44 class AXObject; 44 class AXObject;
45 class ColorChooser; 45 class ColorChooser;
46 class ColorChooserClient; 46 class ColorChooserClient;
47 class DateTimeChooser; 47 class DateTimeChooser;
48 class DateTimeChooserClient; 48 class DateTimeChooserClient;
49 class Element; 49 class Element;
50 class FileChooser; 50 class FileChooser;
51 class FloatRect;
52 class Frame; 51 class Frame;
53 class GraphicsContext; 52 class GraphicsContext;
54 class GraphicsLayer; 53 class GraphicsLayer;
55 class GraphicsLayerFactory; 54 class GraphicsLayerFactory;
56 class HitTestResult; 55 class HitTestResult;
57 class HTMLFormControlElement; 56 class HTMLFormControlElement;
58 class HTMLInputElement; 57 class HTMLInputElement;
59 class IntRect; 58 class IntRect;
60 class LocalFrame; 59 class LocalFrame;
61 class Node; 60 class Node;
62 class Page; 61 class Page;
63 class PagePopupDriver; 62 class PagePopupDriver;
64 class PopupMenuClient; 63 class PopupMenuClient;
65 64
66 struct CompositedSelectionBound; 65 struct CompositedSelectionBound;
67 struct DateTimeChooserParameters; 66 struct DateTimeChooserParameters;
68 struct FrameLoadRequest; 67 struct FrameLoadRequest;
69 struct GraphicsDeviceAdapter; 68 struct GraphicsDeviceAdapter;
70 struct ViewportDescription; 69 struct ViewportDescription;
71 struct WindowFeatures; 70 struct WindowFeatures;
72 71
73 class ChromeClient { 72 class ChromeClient {
74 public: 73 public:
75 virtual void chromeDestroyed() = 0; 74 virtual void chromeDestroyed() = 0;
76 75
77 virtual void setWindowRect(const FloatRect&) = 0; 76 virtual void setWindowRect(const IntRect&) = 0;
78 virtual FloatRect windowRect() = 0; 77 virtual IntRect windowRect() = 0;
79 78
80 virtual FloatRect pageRect() = 0; 79 virtual IntRect pageRect() = 0;
81 80
82 virtual void focus() = 0; 81 virtual void focus() = 0;
83 82
84 virtual bool canTakeFocus(WebFocusType) = 0; 83 virtual bool canTakeFocus(WebFocusType) = 0;
85 virtual void takeFocus(WebFocusType) = 0; 84 virtual void takeFocus(WebFocusType) = 0;
86 85
87 virtual void focusedNodeChanged(Node*, Node*) = 0; 86 virtual void focusedNodeChanged(Node*, Node*) = 0;
88 87
89 virtual void focusedFrameChanged(LocalFrame*) = 0; 88 virtual void focusedFrameChanged(LocalFrame*) = 0;
90 89
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 PromptDialog = 2, 206 PromptDialog = 2,
208 HTMLDialog = 3 207 HTMLDialog = 3
209 }; 208 };
210 virtual bool shouldRunModalDialogDuringPageDismissal(const DialogType&, cons t String&, Document::PageDismissalType) const { return true; } 209 virtual bool shouldRunModalDialogDuringPageDismissal(const DialogType&, cons t String&, Document::PageDismissalType) const { return true; }
211 210
212 virtual bool isSVGImageChromeClient() const { return false; } 211 virtual bool isSVGImageChromeClient() const { return false; }
213 212
214 virtual bool requestPointerLock() { return false; } 213 virtual bool requestPointerLock() { return false; }
215 virtual void requestPointerUnlock() { } 214 virtual void requestPointerUnlock() { }
216 215
217 virtual FloatSize minimumWindowSize() const { return FloatSize(100, 100); } 216 virtual IntSize minimumWindowSize() const { return IntSize(100, 100); }
218 217
219 virtual bool isChromeClientImpl() const { return false; } 218 virtual bool isChromeClientImpl() const { return false; }
220 219
221 virtual void didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMem ber<Element>>&, LocalFrame*) { } 220 virtual void didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMem ber<Element>>&, LocalFrame*) { }
222 virtual void didChangeValueInTextField(HTMLFormControlElement&) { } 221 virtual void didChangeValueInTextField(HTMLFormControlElement&) { }
223 virtual void didEndEditingOnTextField(HTMLInputElement&) { } 222 virtual void didEndEditingOnTextField(HTMLInputElement&) { }
224 virtual void handleKeyboardEventOnTextField(HTMLInputElement&, KeyboardEvent &) { } 223 virtual void handleKeyboardEventOnTextField(HTMLInputElement&, KeyboardEvent &) { }
225 virtual void textFieldDataListChanged(HTMLInputElement&) { } 224 virtual void textFieldDataListChanged(HTMLInputElement&) { }
226 225
227 // Input mehtod editor related functions. 226 // Input mehtod editor related functions.
228 virtual void didCancelCompositionOnSelectionChange() { } 227 virtual void didCancelCompositionOnSelectionChange() { }
229 virtual void willSetInputMethodState() { } 228 virtual void willSetInputMethodState() { }
230 virtual void didUpdateTextOfFocusedElementByNonUserInput() { } 229 virtual void didUpdateTextOfFocusedElementByNonUserInput() { }
231 virtual void showImeIfNeeded() { } 230 virtual void showImeIfNeeded() { }
232 231
233 virtual void registerViewportLayers() const { } 232 virtual void registerViewportLayers() const { }
234 233
235 virtual void showUnhandledTapUIIfNeeded(IntPoint, Node*, bool) { } 234 virtual void showUnhandledTapUIIfNeeded(IntPoint, Node*, bool) { }
236 235
237 protected: 236 protected:
238 virtual ~ChromeClient() { } 237 virtual ~ChromeClient() { }
239 }; 238 };
240 239
241 } // namespace blink 240 } // namespace blink
242 241
243 #endif // ChromeClient_h 242 #endif // ChromeClient_h
OLDNEW
« no previous file with comments | « Source/core/page/Chrome.cpp ('k') | Source/core/page/CreateWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698