Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: Source/core/frame/LocalDOMWindow.h

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/DOMWindow.h ('k') | Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/LocalDOMWindow.h
diff --git a/Source/core/frame/LocalDOMWindow.h b/Source/core/frame/LocalDOMWindow.h
index 6919d4a29f967571e6ad07d6286d1254f05f1a72..573260a0c8f3e770e7dc9930fef1e1a9cba5256d 100644
--- a/Source/core/frame/LocalDOMWindow.h
+++ b/Source/core/frame/LocalDOMWindow.h
@@ -47,8 +47,8 @@ class DocumentInit;
class EventListener;
class EventQueue;
class ExceptionState;
-class FloatRect;
class FrameConsole;
+class IntRect;
class Page;
class PostMessageTimer;
class ScriptCallStack;
@@ -133,10 +133,10 @@ public:
void scrollTo(double x, double y) const override;
void scrollTo(const ScrollToOptions&) const override;
- void moveBy(float x, float y) const override;
- void moveTo(float x, float y) const override;
- void resizeBy(float x, float y) const override;
- void resizeTo(float width, float height) const override;
+ void moveBy(int x, int y) const override;
+ void moveTo(int x, int y, bool hasX, bool hasY) const override;
+ void resizeBy(int x, int y) const override;
+ void resizeTo(int width, int height, bool hasWidth, bool hasHeight) const override;
PassRefPtrWillBeRawPtr<MediaQueryList> matchMedia(const String&) override;
PassRefPtrWillBeRawPtr<CSSStyleDeclaration> getComputedStyle(Element*, const String& pseudoElt) const override;
PassRefPtrWillBeRawPtr<CSSRuleList> getMatchedCSSRules(Element*, const String& pseudoElt) const override;
@@ -154,7 +154,7 @@ public:
unsigned pendingUnloadEventListeners() const;
- static FloatRect adjustWindowRect(LocalFrame&, const FloatRect& pendingChanges);
+ static IntRect adjustWindowRect(LocalFrame&, const IntRect& pendingChanges);
bool allowPopUp(); // Call on first window, not target window.
static bool allowPopUp(LocalFrame& firstFrame);
« no previous file with comments | « Source/core/frame/DOMWindow.h ('k') | Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698