Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Side by Side Diff: Source/core/frame/LocalDOMWindow.h

Issue 879913003: Use IntRect instead of FloatRect for window positions and sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/DOMWindow.h ('k') | Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 29 matching lines...) Expand all
40 40
41 namespace blink { 41 namespace blink {
42 42
43 class DOMWindowEventQueue; 43 class DOMWindowEventQueue;
44 class DOMWindowLifecycleNotifier; 44 class DOMWindowLifecycleNotifier;
45 class DOMWindowProperty; 45 class DOMWindowProperty;
46 class DocumentInit; 46 class DocumentInit;
47 class EventListener; 47 class EventListener;
48 class EventQueue; 48 class EventQueue;
49 class ExceptionState; 49 class ExceptionState;
50 class FloatRect;
51 class FrameConsole; 50 class FrameConsole;
51 class IntRect;
52 class Page; 52 class Page;
53 class PostMessageTimer; 53 class PostMessageTimer;
54 class ScriptCallStack; 54 class ScriptCallStack;
55 class SecurityOrigin; 55 class SecurityOrigin;
56 56
57 enum PageshowEventPersistence { 57 enum PageshowEventPersistence {
58 PageshowEventNotPersisted = 0, 58 PageshowEventNotPersisted = 0,
59 PageshowEventPersisted = 1 59 PageshowEventPersisted = 1
60 }; 60 };
61 61
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 String prompt(const String& message, const String& defaultValue) override; 126 String prompt(const String& message, const String& defaultValue) override;
127 bool find(const String&, bool caseSensitive, bool backwards, bool wrap, bool wholeWord, bool searchInFrames, bool showDialog) const override; 127 bool find(const String&, bool caseSensitive, bool backwards, bool wrap, bool wholeWord, bool searchInFrames, bool showDialog) const override;
128 128
129 // FIXME: ScrollBehaviorSmooth is currently unsupported in PinchViewport. 129 // FIXME: ScrollBehaviorSmooth is currently unsupported in PinchViewport.
130 // crbug.com/434497 130 // crbug.com/434497
131 void scrollBy(double x, double y, ScrollBehavior = ScrollBehaviorAuto) const override; 131 void scrollBy(double x, double y, ScrollBehavior = ScrollBehaviorAuto) const override;
132 void scrollBy(const ScrollToOptions&) const override; 132 void scrollBy(const ScrollToOptions&) const override;
133 void scrollTo(double x, double y) const override; 133 void scrollTo(double x, double y) const override;
134 void scrollTo(const ScrollToOptions&) const override; 134 void scrollTo(const ScrollToOptions&) const override;
135 135
136 void moveBy(float x, float y) const override; 136 void moveBy(int x, int y) const override;
137 void moveTo(float x, float y) const override; 137 void moveTo(int x, int y, bool hasX, bool hasY) const override;
138 void resizeBy(float x, float y) const override; 138 void resizeBy(int x, int y) const override;
139 void resizeTo(float width, float height) const override; 139 void resizeTo(int width, int height, bool hasWidth, bool hasHeight) const ov erride;
140 PassRefPtrWillBeRawPtr<MediaQueryList> matchMedia(const String&) override; 140 PassRefPtrWillBeRawPtr<MediaQueryList> matchMedia(const String&) override;
141 PassRefPtrWillBeRawPtr<CSSStyleDeclaration> getComputedStyle(Element*, const String& pseudoElt) const override; 141 PassRefPtrWillBeRawPtr<CSSStyleDeclaration> getComputedStyle(Element*, const String& pseudoElt) const override;
142 PassRefPtrWillBeRawPtr<CSSRuleList> getMatchedCSSRules(Element*, const Strin g& pseudoElt) const override; 142 PassRefPtrWillBeRawPtr<CSSRuleList> getMatchedCSSRules(Element*, const Strin g& pseudoElt) const override;
143 int requestAnimationFrame(RequestAnimationFrameCallback*) override; 143 int requestAnimationFrame(RequestAnimationFrameCallback*) override;
144 int webkitRequestAnimationFrame(RequestAnimationFrameCallback*) override; 144 int webkitRequestAnimationFrame(RequestAnimationFrameCallback*) override;
145 void cancelAnimationFrame(int id) override; 145 void cancelAnimationFrame(int id) override;
146 void postMessage(PassRefPtr<SerializedScriptValue> message, const MessagePor tArray*, const String& targetOrigin, LocalDOMWindow* source, ExceptionState&) ov erride; 146 void postMessage(PassRefPtr<SerializedScriptValue> message, const MessagePor tArray*, const String& targetOrigin, LocalDOMWindow* source, ExceptionState&) ov erride;
147 String crossDomainAccessErrorMessage(LocalDOMWindow* callingWindow) override ; 147 String crossDomainAccessErrorMessage(LocalDOMWindow* callingWindow) override ;
148 String sanitizedCrossDomainAccessErrorMessage(LocalDOMWindow* callingWindow) override; 148 String sanitizedCrossDomainAccessErrorMessage(LocalDOMWindow* callingWindow) override;
149 149
150 void registerProperty(DOMWindowProperty*); 150 void registerProperty(DOMWindowProperty*);
151 void unregisterProperty(DOMWindowProperty*); 151 void unregisterProperty(DOMWindowProperty*);
152 152
153 void reset(); 153 void reset();
154 154
155 unsigned pendingUnloadEventListeners() const; 155 unsigned pendingUnloadEventListeners() const;
156 156
157 static FloatRect adjustWindowRect(LocalFrame&, const FloatRect& pendingChang es); 157 static IntRect adjustWindowRect(LocalFrame&, const IntRect& pendingChanges);
158 158
159 bool allowPopUp(); // Call on first window, not target window. 159 bool allowPopUp(); // Call on first window, not target window.
160 static bool allowPopUp(LocalFrame& firstFrame); 160 static bool allowPopUp(LocalFrame& firstFrame);
161 static bool canShowModalDialogNow(const LocalFrame*); 161 static bool canShowModalDialogNow(const LocalFrame*);
162 162
163 Element* frameElement() const; 163 Element* frameElement() const;
164 164
165 PassRefPtrWillBeRawPtr<DOMWindow> open(const String& urlString, const Atomic String& frameName, const String& windowFeaturesString, 165 PassRefPtrWillBeRawPtr<DOMWindow> open(const String& urlString, const Atomic String& frameName, const String& windowFeaturesString,
166 LocalDOMWindow* callingWindow, LocalDOMWindow* enteredWindow); 166 LocalDOMWindow* callingWindow, LocalDOMWindow* enteredWindow);
167 167
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 } 313 }
314 314
315 inline String LocalDOMWindow::defaultStatus() const 315 inline String LocalDOMWindow::defaultStatus() const
316 { 316 {
317 return m_defaultStatus; 317 return m_defaultStatus;
318 } 318 }
319 319
320 } // namespace blink 320 } // namespace blink
321 321
322 #endif // LocalDOMWindow_h 322 #endif // LocalDOMWindow_h
OLDNEW
« no previous file with comments | « Source/core/frame/DOMWindow.h ('k') | Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698