Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 879793002: Make ChromeOS captive portal notification text same as desktop (Closed)

Created:
5 years, 10 months ago by meacer
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ChromeOS captive portal notification text same as desktop BUG=425339 Committed: https://crrev.com/6863146f851cf3c9f6cabf74c5a4172cd9aa04ce Cr-Commit-Position: refs/heads/master@{#316689}

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller.cc View 1 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
meacer
ygorshenin: Can you PTAL? For reference, here is a screenshot of the change: https://drive.google.com/file/d/0B9q2eN9gDoUIQ2RqRXBKYW5Uc2c/view?usp=sharing
5 years, 10 months ago (2015-02-06 23:04:05 UTC) #2
meacer
Ping?
5 years, 10 months ago (2015-02-11 21:48:44 UTC) #3
Nikita (slow)
lgtm ygroshenin@ is no longer at Google.
5 years, 10 months ago (2015-02-16 08:40:46 UTC) #5
meacer
On 2015/02/16 08:40:46, Nikita wrote: > lgtm > > ygroshenin@ is no longer at Google. ...
5 years, 10 months ago (2015-02-17 18:26:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879793002/20001
5 years, 10 months ago (2015-02-17 18:27:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/43237)
5 years, 10 months ago (2015-02-17 18:33:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879793002/40001
5 years, 10 months ago (2015-02-17 22:29:31 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-17 22:57:03 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:57:48 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6863146f851cf3c9f6cabf74c5a4172cd9aa04ce
Cr-Commit-Position: refs/heads/master@{#316689}

Powered by Google App Engine
This is Rietveld 408576698