chrome/app/chromeos_strings.grdp - Issue 879793002: Make ChromeOS captive portal notification text same as desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chromeos_strings.grdp

Issue 879793002: Make ChromeOS captive portal notification text same as desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chromeos_strings.grdp

diff --git a/chrome/app/chromeos_strings.grdp b/chrome/app/chromeos_strings.grdp

index 52352c8831ee758a77566b3f672aad606375271c..3579ce95253e6be91f98b86dd1ff96a0302e76be 100644

--- a/chrome/app/chromeos_strings.grdp

+++ b/chrome/app/chromeos_strings.grdp

@@ -5490,11 +5490,17 @@ All users must sign out to continue.

If enabled, notification is displayed when device is connected to a network behind captive portal.

</message>

- <message name="IDS_PORTAL_DETECTION_NOTIFICATION_TITLE" desc="Title for the system notification that current network is behind captive portal">

- Action required to connect

+ <message name="IDS_PORTAL_DETECTION_NOTIFICATION_TITLE_WIRED" desc="Title for the system notification that current wired network is behind captive portal">

+ Connect to network

</message>

- <message name="IDS_PORTAL_DETECTION_NOTIFICATION_MESSAGE" desc="Body of the system notification that the current network is behind captive portal">

- To use <ph name="NETWORK_ID">$1<ex>Public Wifi</ex></ph> you need to visit the network's login page. Click to go to login page.

+ <message name="IDS_PORTAL_DETECTION_NOTIFICATION_TITLE_WIFI" desc="Title for the system notification that current Wi-Fi network is behind captive portal">

+ Connect to Wi-Fi

+ </message>

+ <message name="IDS_PORTAL_DETECTION_NOTIFICATION_MESSAGE_WIRED" desc="Body of the system notification that current wired network is behind captive portal">

+ The network you are using (<ph name="NETWORK_ID">$1<ex>Public Network</ex></ph>) may require you to visit its login page.

+ </message>

+ <message name="IDS_PORTAL_DETECTION_NOTIFICATION_MESSAGE_WIFI" desc="Body of the system notification that current Wi-Fi network is behind captive portal">

+ The Wi-Fi you are using (<ph name="NETWORK_ID">$1<ex>Public Network</ex></ph>) may require you to visit its login page.

</message>

<ph name="NETWORK_ID">$1<ex>Public Wifi</ex></ph> may require visiting<ph name="LOGIN_URL">$2<ex>portal.ipass.net</ex></ph> to complete your connection..

« no previous file with comments | « no previous file | chrome/browser/chromeos/net/network_portal_notification_controller.cc » ('j') | no next file with comments »