Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 879783004: Cleanup: Don't bother doing no-op wide/utf16 conversions on Windows. (Closed)

Created:
5 years, 11 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
sadrul, mef
CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Don't bother doing no-op wide/utf16 conversions on Windows. Committed: https://crrev.com/19f53ecc5116b38b2b080380223dd52f78300e37 Cr-Commit-Position: refs/heads/master@{#313947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -32 lines) Patch
M chrome/browser/jumplist_win.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/crash/app/crash_keys_win.cc View 3 chunks +15 lines, -16 lines 0 comments Download
M net/base/filename_util_internal.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
5 years, 10 months ago (2015-01-29 22:35:45 UTC) #2
sadrul
rs lgtm
5 years, 10 months ago (2015-01-30 00:04:59 UTC) #4
Lei Zhang
+mef for net/
5 years, 10 months ago (2015-01-30 00:21:30 UTC) #6
mef
net lgtm
5 years, 10 months ago (2015-01-30 15:54:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879783004/1
5 years, 10 months ago (2015-01-30 17:38:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 18:25:12 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 18:25:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19f53ecc5116b38b2b080380223dd52f78300e37
Cr-Commit-Position: refs/heads/master@{#313947}

Powered by Google App Engine
This is Rietveld 408576698