chrome/browser/ui/webui/version_ui.cc - Issue 879783004: Cleanup: Don't bother doing no-op wide/utf16 conversions on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/version_ui.cc

Issue 879783004: Cleanup: Don't bother doing no-op wide/utf16 conversions on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/version_ui.cc

diff --git a/chrome/browser/ui/webui/version_ui.cc b/chrome/browser/ui/webui/version_ui.cc

index 7956a10a10749e47bc19890809d6c35fb5e2e6bf..6ec651a9b2215cba85ad5c00fe4105d30ec38299 100644

--- a/chrome/browser/ui/webui/version_ui.cc

+++ b/chrome/browser/ui/webui/version_ui.cc

@@ -6,7 +6,6 @@

#include "base/command_line.h"

#include "base/strings/string_number_conversions.h"

-#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/webui/version_handler.h"

#include "chrome/common/chrome_content_client.h"

@@ -97,8 +96,7 @@ WebUIDataSource* CreateVersionUIDataSource() {

#if defined(OS_WIN)

html_source->AddString(

"command_line",

- base::WideToUTF16(

- base::CommandLine::ForCurrentProcess()->GetCommandLineString()));

+ base::CommandLine::ForCurrentProcess()->GetCommandLineString());

#elif defined(OS_POSIX)

std::string command_line;

typedef std::vector<std::string> ArgvList;

« no previous file with comments | « chrome/browser/jumplist_win.cc ('k') | chrome/utility/importer/ie_importer_win.cc » ('j') | no next file with comments »