Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 879763003: [telemetry] Disable inbox_benchmark.Inbox. (Closed)

Created:
5 years, 11 months ago by dtu
Modified:
5 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Disable inbox_benchmark.Inbox. Failing on the bots. See: http://build.chromium.org/p/chromium.perf/builders/Mac%2010.9%20Perf%20%285%29/builds/3254 BUG=452257 TBR=manisharora@google.com Committed: https://crrev.com/8beee9b0b61789d0b54f4b3cd83f2d8d450da77d Cr-Commit-Position: refs/heads/master@{#313206}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment out the benchmark. #

Patch Set 3 : Explainer comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M tools/perf/benchmarks/inbox_benchmark.py View 1 2 1 chunk +13 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
dtu
5 years, 11 months ago (2015-01-26 23:14:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879763003/1
5 years, 11 months ago (2015-01-26 23:15:34 UTC) #4
sullivan
lgtm
5 years, 11 months ago (2015-01-26 23:17:03 UTC) #6
nednguyen
https://codereview.chromium.org/879763003/diff/1/tools/perf/benchmarks/inbox_benchmark.py File tools/perf/benchmarks/inbox_benchmark.py (right): https://codereview.chromium.org/879763003/diff/1/tools/perf/benchmarks/inbox_benchmark.py#newcode10 tools/perf/benchmarks/inbox_benchmark.py:10: class Inbox(benchmark.Benchmark): I think you need to remove benchmark ...
5 years, 11 months ago (2015-01-26 23:44:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879763003/40001
5 years, 11 months ago (2015-01-27 00:20:29 UTC) #13
nednguyen
lgtm
5 years, 11 months ago (2015-01-27 00:21:54 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-27 02:22:43 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 02:23:36 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8beee9b0b61789d0b54f4b3cd83f2d8d450da77d
Cr-Commit-Position: refs/heads/master@{#313206}

Powered by Google App Engine
This is Rietveld 408576698