tools/perf/benchmarks/inbox_benchmark.py - Issue 879763003: [telemetry] Disable inbox_benchmark.Inbox.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/benchmarks/inbox_benchmark.py

Issue 879763003: [telemetry] Disable inbox_benchmark.Inbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from page_sets import inbox	5 from page_sets import inbox

6 from telemetry import benchmark	6 from telemetry import benchmark

7 from telemetry.web_perf import timeline_based_measurement	7 from telemetry.web_perf import timeline_based_measurement

8	8

9 @benchmark.Disabled('android')	9 @benchmark.Disabled

10 class Inbox(benchmark.Benchmark):	10 class Inbox(benchmark.Benchmark):
	nednguyen 2015/01/26 23:44:32 I think you need to remove benchmark entirely or c I think you need to remove benchmark entirely or comment out the benchmark class. The _UpdateAndCheckArchives is done before SharedUserStoryState(SharedPageState) is initated. The logic for checking whether the test can be run on the platform is done when it's constructed. (see https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...)
11 """Runs the timeline based measurement against inbox pageset."""	11 """Runs the timeline based measurement against inbox pageset."""

12 test = timeline_based_measurement.TimelineBasedMeasurement	12 test = timeline_based_measurement.TimelineBasedMeasurement

13	13

14 def CreatePageSet(self, options):	14 def CreatePageSet(self, options):

15 return inbox.InboxPageSet()	15 return inbox.InboxPageSet()

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »