Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 879723002: When receiving OOB data on a socket, return ERR_OOB_DATA.

Created:
5 years, 11 months ago by Robert Sesek
Modified:
5 years, 11 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When receiving OOB data on a socket, return ERR_OOB_DATA. On OS X, the libevent kqueue will raise EVFILT_READ for OOB data, even though a normal read() will not clear it. This can lead to an infinte ERR_IO_PENDING loop. Instead, try to clear the OOB data if the read() returns 0. BUG=437642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M net/base/net_error_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/socket_libevent.cc View 1 chunk +14 lines, -1 line 0 comments Download
M net/socket/tcp_socket_libevent.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/socket/tcp_socket_libevent.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/tcp_socket_unittest.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M net/socket/tcp_socket_win.h View 1 chunk +2 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698