Source/bindings/v8/custom/V8CryptoCustom.cpp - Issue 87963002: Improve Crypto::getRandomValues exception messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8CryptoCustom.cpp

Issue 87963002: Improve Crypto::getRandomValues exception messages. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: DEBUG. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8CryptoCustom.cpp

diff --git a/Source/bindings/v8/custom/V8CryptoCustom.cpp b/Source/bindings/v8/custom/V8CryptoCustom.cpp

index a515a7732e2083f13268014a941cccc8d864f22e..7abea6ff09c507804054fc10101871e2ae6bb7b8 100644

--- a/Source/bindings/v8/custom/V8CryptoCustom.cpp

+++ b/Source/bindings/v8/custom/V8CryptoCustom.cpp

@@ -55,7 +55,7 @@ void V8Crypto::getRandomValuesMethodCustom(const v8::FunctionCallbackInfo<v8::Va

ArrayBufferView* arrayBufferView = V8ArrayBufferView::toNative(v8::Handle<v8::Object>::Cast(buffer));

ASSERT(arrayBufferView);

- ExceptionState exceptionState(info.Holder(), info.GetIsolate());

+ ExceptionState exceptionState(ExceptionState::ExecutionContext, "getRandomValues", "Crypto", info.Holder(), info.GetIsolate());

Crypto::getRandomValues(arrayBufferView, exceptionState);

if (exceptionState.throwIfNeeded())

« no previous file with comments | « Source/bindings/v8/ExceptionState.cpp ('k') | Source/modules/crypto/Crypto.cpp » ('j') | no next file with comments »