Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Side by Side Diff: Source/bindings/v8/custom/V8CryptoCustom.cpp

Issue 87963002: Improve Crypto::getRandomValues exception messages. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: DEBUG. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/ExceptionState.cpp ('k') | Source/modules/crypto/Crypto.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 v8::Handle<v8::Value> buffer = info[0]; 49 v8::Handle<v8::Value> buffer = info[0];
50 if (!V8ArrayBufferView::hasInstance(buffer, info.GetIsolate(), worldType(inf o.GetIsolate()))) { 50 if (!V8ArrayBufferView::hasInstance(buffer, info.GetIsolate(), worldType(inf o.GetIsolate()))) {
51 throwTypeError("First argument is not an ArrayBufferView", info.GetIsola te()); 51 throwTypeError("First argument is not an ArrayBufferView", info.GetIsola te());
52 return; 52 return;
53 } 53 }
54 54
55 ArrayBufferView* arrayBufferView = V8ArrayBufferView::toNative(v8::Handle<v8 ::Object>::Cast(buffer)); 55 ArrayBufferView* arrayBufferView = V8ArrayBufferView::toNative(v8::Handle<v8 ::Object>::Cast(buffer));
56 ASSERT(arrayBufferView); 56 ASSERT(arrayBufferView);
57 57
58 ExceptionState exceptionState(info.Holder(), info.GetIsolate()); 58 ExceptionState exceptionState(ExceptionState::ExecutionContext, "getRandomVa lues", "Crypto", info.Holder(), info.GetIsolate());
59 Crypto::getRandomValues(arrayBufferView, exceptionState); 59 Crypto::getRandomValues(arrayBufferView, exceptionState);
60 60
61 if (exceptionState.throwIfNeeded()) 61 if (exceptionState.throwIfNeeded())
62 return; 62 return;
63 63
64 v8SetReturnValue(info, buffer); 64 v8SetReturnValue(info, buffer);
65 } 65 }
66 66
67 } // namespace WebCore 67 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/ExceptionState.cpp ('k') | Source/modules/crypto/Crypto.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698