Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 879543004: Fix ASSERT in Sky when dragging outside the window on linux (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel
CC:
eseidel, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix ASSERT in Sky when dragging outside the window on linux We don't seem to receive mojo::EVENT_TYPE_MOUSE_EXITED when the mouse exits our mojo::View. We should find out if that's a bug with the Mojo event system, but for now this CL adds a fake cancel event the next time the mouse goes down to at least keep the state machine on the right track. BUG=https://github.com/domokit/mojo/issues/40 R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4393ecb1208f1fbc9aed551b39eaaa2c31dcd18a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M sky/engine/core/frame/NewEventHandler.cpp View 3 chunks +29 lines, -7 lines 0 comments Download
M sky/viewer/converters/input_event_types.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-26 18:11:08 UTC) #1
eseidel
lgtm
5 years, 11 months ago (2015-01-26 18:51:25 UTC) #3
abarth-chromium
5 years, 11 months ago (2015-01-26 18:53:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4393ecb1208f1fbc9aed551b39eaaa2c31dcd18a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698