Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: sky/viewer/converters/input_event_types.cc

Issue 879543004: Fix ASSERT in Sky when dragging outside the window on linux (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/NewEventHandler.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/viewer/converters/input_event_types.cc
diff --git a/sky/viewer/converters/input_event_types.cc b/sky/viewer/converters/input_event_types.cc
index d63d71b70497b07ddc3b8aea55d3619141600a72..ae3d1bcd9e785425e26f43a91646724ad2d6634d 100644
--- a/sky/viewer/converters/input_event_types.cc
+++ b/sky/viewer/converters/input_event_types.cc
@@ -46,7 +46,8 @@ scoped_ptr<blink::WebInputEvent> BuildWebPointerEvent(
web_event->type = blink::WebInputEvent::PointerUp;
break;
case mojo::EVENT_TYPE_TOUCH_CANCELLED:
- case mojo::EVENT_TYPE_MOUSE_EXITED:
+ // FIXME: What mouse event should we listen to in order to learn when the
+ // mouse moves out of the mojo::View?
web_event->type = blink::WebInputEvent::PointerCancel;
break;
default:
@@ -207,7 +208,6 @@ scoped_ptr<blink::WebInputEvent> ConvertEvent(const mojo::EventPtr& event,
event->action == mojo::EVENT_TYPE_TOUCH_MOVED ||
event->action == mojo::EVENT_TYPE_TOUCH_CANCELLED ||
event->action == mojo::EVENT_TYPE_MOUSE_DRAGGED ||
- event->action == mojo::EVENT_TYPE_MOUSE_EXITED ||
event->action == mojo::EVENT_TYPE_MOUSE_PRESSED ||
event->action == mojo::EVENT_TYPE_MOUSE_RELEASED) {
return BuildWebPointerEvent(event, device_pixel_ratio);
« no previous file with comments | « sky/engine/core/frame/NewEventHandler.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698