Source/platform/blink_platform.gypi - Issue 879533003: Remove Mac native font type members from FontPlatformData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/blink_platform.gypi

Issue 879533003: Remove Mac native font type members from FontPlatformData (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Memory management review comments addressed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/platform/blink_platform.gyp ('k') | Source/platform/fonts/FontCustomPlatformData.h » ('j') | Source/platform/fonts/mac/FontPlatformDataMac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/blink_platform.gypi

diff --git a/Source/platform/blink_platform.gypi b/Source/platform/blink_platform.gypi

index a3c67239e77f1af8ee25fe26b761813a94dc6e1a..effa9b3ee9ac0669c1300f73c2c28c89b8326eb3 100644

--- a/Source/platform/blink_platform.gypi

+++ b/Source/platform/blink_platform.gypi

@@ -355,6 +355,7 @@

'fonts/FontCacheClient.h',

'fonts/FontCacheKey.h',

'fonts/FontCustomPlatformData.h',

+ 'fonts/FontCustomPlatformData.cpp',

'fonts/FontData.cpp',

'fonts/FontData.h',

'fonts/FontDataCache.cpp',

@@ -392,10 +393,7 @@

'fonts/mac/FontFamilyMatcherMac.h',

'fonts/mac/FontFamilyMatcherMac.mm',

'fonts/mac/FontCacheMac.mm',

- 'fonts/mac/FontCustomPlatformDataMac.cpp',

'fonts/mac/FontPlatformDataMac.mm',

- 'fonts/mac/MemoryActivatedFont.h',

- 'fonts/mac/MemoryActivatedFont.mm',

'fonts/opentype/OpenTypeSanitizer.cpp',

'fonts/opentype/OpenTypeSanitizer.h',

'fonts/opentype/OpenTypeTypes.h',

@@ -410,7 +408,6 @@

'fonts/shaping/SimpleShaper.cpp',

'fonts/shaping/SimpleShaper.h',

'fonts/skia/FontCacheSkia.cpp',

- 'fonts/skia/FontCustomPlatformDataSkia.cpp',

'fonts/win/FontCacheSkiaWin.cpp',

'fonts/win/FontFallbackWin.cpp',

'fonts/win/FontFallbackWin.h',

« no previous file with comments | « Source/platform/blink_platform.gyp ('k') | Source/platform/fonts/FontCustomPlatformData.h » ('j') | Source/platform/fonts/mac/FontPlatformDataMac.mm » ('J')