Source/platform/blink_platform.gyp - Issue 879533003: Remove Mac native font type members from FontPlatformData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/blink_platform.gyp

Issue 879533003: Remove Mac native font type members from FontPlatformData (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Memory management review comments addressed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/blink_platform.gyp

diff --git a/Source/platform/blink_platform.gyp b/Source/platform/blink_platform.gyp

index f685525c35fb3a4a86c72b61c8f6365b5f96c56b..07f187c3b688f8e072c26c9818e5451e2fac3797 100644

--- a/Source/platform/blink_platform.gyp

+++ b/Source/platform/blink_platform.gyp

@@ -317,10 +317,6 @@

['exclude', 'scroll/ScrollAnimatorNone\\.cpp$'],

['exclude', 'scroll/ScrollAnimatorNone\\.h$'],

- # The Mac currently uses FontCustomPlatformDataMac.cpp,

- # included by regex above, instead.

- ['exclude', 'fonts/skia/FontCustomPlatformDataSkia\\.cpp$'],

['exclude', 'fonts/skia/FontCacheSkia\\.cpp$'],

['include', 'geometry/mac/FloatPointMac\\.mm$'],

@@ -358,8 +354,6 @@

['include', 'clipboard/ClipboardUtilitiesWin\\.(cpp|h)$'],

['include', 'fonts/opentype/'],

- ['include', 'fonts/skia/FontCustomPlatformDataSkia\\.cpp$'],

['include', 'fonts/win/FontCacheSkiaWin\\.cpp$'],

['include', 'fonts/win/FontFallbackWin\\.(cpp|h)$'],

['include', 'fonts/win/FontPlatformDataWin\\.cpp$'],

« no previous file with comments | « no previous file | Source/platform/blink_platform.gypi » ('j') | Source/platform/fonts/mac/FontPlatformDataMac.mm » ('J')