Workaround for chrome://net-internals debug crash on Android.

Workaround for chrome://net-internals debug crash on Android.

BUG=453088
Committed: https://crrev.com/c945f824465a09aa841e6b836b5b12997dfb8747
Cr-Commit-Position: refs/heads/master@{#313929}

[jeremyim, 2015-01-28 22:10:49]

jeremyim@chromium.org changed reviewers:
+ mmenke@chromium.org

[jeremyim, 2015-01-28 22:10:50]

PTAL! =)

[jeremyim, 2015-01-28 22:12:04]

https://codereview.chromium.org/879383004/diff/1/net/base/net_log_util.cc
File net/base/net_log_util.cc (right):

https://codereview.chromium.org/879383004/diff/1/net/base/net_log_util.cc#new...
net/base/net_log_util.cc:540: // TODO(mmenke) This DCHECK fails on Android.
Alternatively, this could be wrapped with 
#if !defined(ANDROID_OS) to keep the DCHECK available on non-Android platforms.

[mmenke, 2015-01-30 15:17:14]

https://codereview.chromium.org/879383004/diff/1/net/base/net_log_util.cc
File net/base/net_log_util.cc (right):

https://codereview.chromium.org/879383004/diff/1/net/base/net_log_util.cc#new...
net/base/net_log_util.cc:541: // DCHECK_EQ((*contexts.begin())->net_log(),
context->net_log());
Outputting requests from two different NetLogs (Or from a NULL NetLog and a
non-NULL one) to a single observer really makes no sense.

I'd rather just have the call to  PrePopulateEventList() in net_internals_ui
skipped entirely on Android. 
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[jeremyim, 2015-01-30 15:48:07]

https://codereview.chromium.org/879383004/diff/1/net/base/net_log_util.cc
File net/base/net_log_util.cc (right):

https://codereview.chromium.org/879383004/diff/1/net/base/net_log_util.cc#new...
net/base/net_log_util.cc:541: // DCHECK_EQ((*contexts.begin())->net_log(),
context->net_log());
On 2015/01/30 15:17:14, mmenke wrote:
> Outputting requests from two different NetLogs (Or from a NULL NetLog and a
> non-NULL one) to a single observer really makes no sense.
> 
> I'd rather just have the call to  PrePopulateEventList() in net_internals_ui
> skipped entirely on Android. 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

Done.

[mmenke, 2015-01-30 15:49:45]

LGTM, modulo comments.

https://codereview.chromium.org/879383004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/879383004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:708: #if
!defined(OS_ANDROID)
Please add a TODO(mmenke) with link to the bug, and update the CL description to
indicate this is a workaround, not a fix.

[jeremyim, 2015-01-30 16:23:00]

Thanks for looking at this!

https://codereview.chromium.org/879383004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/879383004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:708: #if
!defined(OS_ANDROID)
On 2015/01/30 15:49:44, mmenke wrote:
> Please add a TODO(mmenke) with link to the bug, and update the CL description
to
> indicate this is a workaround, not a fix.

Done.

[jeremyim, 2015-01-30 16:23:06]

The CQ bit was checked by jeremyim@chromium.org

[commit-bot: I haz the power, 2015-01-30 16:23:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/879383004/40001

[commit-bot: I haz the power, 2015-01-30 17:18:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-30 17:19:36]

Patchset 3 (id:??) landed as
https://crrev.com/c945f824465a09aa841e6b836b5b12997dfb8747
Cr-Commit-Position: refs/heads/master@{#313929}