chrome/browser/ui/webui/net_internals/net_internals_ui.cc - Issue 879383004: Workaround for chrome://net-internals debug crash on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Issue 879383004: Workaround for chrome://net-internals debug crash on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

index 93022ab164d1b9c95e7c114f2f03fbf74bf6b42c..f3c02bc0c7c5c6d47caedb120efe44fc3f79c740 100644

--- a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

@@ -705,7 +705,11 @@ void NetInternalsMessageHandler::IOThreadImpl::OnRendererReady(

SendJavascriptCommand("receivedConstants", NetInternalsUI::GetConstants());

+ // TODO(mmenke) DCHECK in CreateNetLogEntriesForActiveObjects in

+ // net_log_util.cc fails on Android (https://www.crbug.com/453088)

+#if !defined(OS_ANDROID)

PrePopulateEventList();

+#endif

// Register with network stack to observe events.

io_thread_->net_log()->AddThreadSafeObserver(this,

« no previous file with comments | « no previous file | no next file » | no next file with comments »