Adding tests for HTMLSelect add() api

Adding tests for HTMLSelect add() api

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190110

[shiva.jm, 2015-01-28 10:48:57]

shiva.jm@samsung.com changed reviewers:
+ a.cavalcanti@samsung.com

[shiva.jm, 2015-01-28 10:48:57]

Added new tests for HTMLSelect add() api to check for more inputs like bool,
large intergers and more than allowed arguments.

[shiva.jm, 2015-02-12 11:19:44]

These feature and tests was added as part of
https://codereview.chromium.org/213773003 and
https://codereview.chromium.org/716773002

[shiva.jm, 2015-02-13 03:34:23]

shiva.jm@samsung.com changed reviewers:
+ bashi@chromium.org, haraken@chromium.org

[shiva.jm, 2015-02-13 03:34:23]

pls have a look.

[haraken, 2015-02-13 04:00:10]

LGTM

[shiva.jm, 2015-02-13 04:10:41]

The CQ bit was checked by shiva.jm@samsung.com

[commit-bot: I haz the power, 2015-02-13 04:11:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/879273002/1

[bashi, 2015-02-13 04:21:49]

https://codereview.chromium.org/879273002/diff/1/LayoutTests/fast/forms/selec...
File LayoutTests/fast/forms/select/select-add.html (right):

https://codereview.chromium.org/879273002/diff/1/LayoutTests/fast/forms/selec...
LayoutTests/fast/forms/select/select-add.html:99:
shouldBeEqualToString('addOption(2147483648)', '0,1,2,X');
Is this an expected behavior?

[shiva.jm, 2015-02-13 04:43:57]

I think as in link:
http://www.w3.org/html/wg/drafts/html/master/forms.html#dom-select-add and
https://html.spec.whatwg.org/multipage/forms.html#the-select-element, out of
range numbers should get added to the end of list( If before is omitted, null,
or a number out of range, then element will be added at the end of the list)

https://codereview.chromium.org/879273002/diff/1/LayoutTests/fast/forms/selec...
File LayoutTests/fast/forms/select/select-add.html (right):

https://codereview.chromium.org/879273002/diff/1/LayoutTests/fast/forms/selec...
LayoutTests/fast/forms/select/select-add.html:99:
shouldBeEqualToString('addOption(2147483648)', '0,1,2,X');
On 2015/02/13 04:21:49, bashi1 wrote:
> Is this an expected behavior?

I think as in link:
http://www.w3.org/html/wg/drafts/html/master/forms.html#dom-select-add and
https://html.spec.whatwg.org/multipage/forms.html#the-select-element, out of
range numbers should get added to the end of list( If before is omitted, null,
or a number out of range, then element will be added at the end of the list).

[bashi, 2015-02-13 04:50:29]

https://codereview.chromium.org/879273002/diff/1/LayoutTests/fast/forms/selec...
File LayoutTests/fast/forms/select/select-add.html (right):

https://codereview.chromium.org/879273002/diff/1/LayoutTests/fast/forms/selec...
LayoutTests/fast/forms/select/select-add.html:99:
shouldBeEqualToString('addOption(2147483648)', '0,1,2,X');
On 2015/02/13 04:43:57, shiva.jm wrote:
> On 2015/02/13 04:21:49, bashi1 wrote:
> > Is this an expected behavior?
> 
> I think as in link:
> http://www.w3.org/html/wg/drafts/html/master/forms.html#dom-select-add and
> https://html.spec.whatwg.org/multipage/forms.html#the-select-element, out of
> range numbers should get added to the end of list( If before is omitted, null,
> or a number out of range, then element will be added at the end of the list).

Per the IDL spec, I guess that a TypeError should be thrown.
http://heycam.github.io/webidl/#es-long

That said, I'm not suggesting that we should change the behavior now. I just
wanted to confirm what we are testing here.

[bashi, 2015-02-13 04:56:34]

On 2015/02/13 04:50:29, bashi1 wrote:
>
https://codereview.chromium.org/879273002/diff/1/LayoutTests/fast/forms/selec...
> File LayoutTests/fast/forms/select/select-add.html (right):
> 
>
https://codereview.chromium.org/879273002/diff/1/LayoutTests/fast/forms/selec...
> LayoutTests/fast/forms/select/select-add.html:99:
> shouldBeEqualToString('addOption(2147483648)', '0,1,2,X');
> On 2015/02/13 04:43:57, shiva.jm wrote:
> > On 2015/02/13 04:21:49, bashi1 wrote:
> > > Is this an expected behavior?
> > 
> > I think as in link:
> > http://www.w3.org/html/wg/drafts/html/master/forms.html#dom-select-add and
> > https://html.spec.whatwg.org/multipage/forms.html#the-select-element, out of
> > range numbers should get added to the end of list( If before is omitted,
null,
> > or a number out of range, then element will be added at the end of the
list).
> 
> Per the IDL spec, I guess that a TypeError should be thrown.
> http://heycam.github.io/webidl/#es-long
> 
> That said, I'm not suggesting that we should change the behavior now. I just
> wanted to confirm what we are testing here.

Ignore this, I was wrong. No [EnforceRange] here. Sorry for the noise..

[commit-bot: I haz the power, 2015-02-13 05:24:58]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190110