Don't call preventDefault in the FocusGrid's click event

Don't call preventDefault in the FocusGrid's click event

Calling preventDefault in the click event prevents buttons from handling the event.

BUG=455617
Committed: https://crrev.com/7ea968e9d783d6108500fe4ef54d1a63ab96de7f
Cr-Commit-Position: refs/heads/master@{#314911}

[hcarmona, 2015-02-05 18:39:21]

hcarmona@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-02-05 19:31:10]

https://codereview.chromium.org/879243007/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/focus_grid.js (left):

https://codereview.chromium.org/879243007/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/focus_grid.js:68: e.preventDefault();
when/why was this added?

[hcarmona, 2015-02-05 21:16:09]

https://codereview.chromium.org/879243007/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/focus_grid.js (left):

https://codereview.chromium.org/879243007/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/focus_grid.js:68: e.preventDefault();
On 2015/02/05 19:31:10, Dan Beam wrote:
> when/why was this added?

This was added as part of the downloads changes. It shouldn't be there. Buttons
are the only element that doesn't work so this wasn't caught because all other
links worked fine.

This function makes sure that there are no lingering "active" rows when an item
is clicked. So it doesn't make sense to stop event handling at this point.

[Dan Beam, 2015-02-05 21:20:36]

https://codereview.chromium.org/879243007/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/focus_grid.js (left):

https://codereview.chromium.org/879243007/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/focus_grid.js:68: e.preventDefault();
On 2015/02/05 21:16:09, Hector Carmona wrote:
> On 2015/02/05 19:31:10, Dan Beam wrote:
> > when/why was this added?
> 
> This was added as part of the downloads changes. It shouldn't be there.
Buttons
> are the only element that doesn't work so this wasn't caught because all other
> links worked fine.
> 
> This function makes sure that there are no lingering "active" rows when an
item
> is clicked. So it doesn't make sense to stop event handling at this point.

are you sure you're not confusing preventDefault() with stopPropagation()?

[Dan Beam, 2015-02-05 22:12:18]

lgtm after offline chat

[hcarmona, 2015-02-05 22:18:14]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2015-02-05 22:19:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/879243007/1

[commit-bot: I haz the power, 2015-02-05 23:21:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-05 23:22:24]

Patchset 1 (id:??) landed as
https://crrev.com/7ea968e9d783d6108500fe4ef54d1a63ab96de7f
Cr-Commit-Position: refs/heads/master@{#314911}