Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: ui/webui/resources/js/cr/ui/focus_grid.js

Issue 879243007: Don't call preventDefault in the FocusGrid's click event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/cr/ui/focus_grid.js
diff --git a/ui/webui/resources/js/cr/ui/focus_grid.js b/ui/webui/resources/js/cr/ui/focus_grid.js
index 4ff1635f06f3fce2e1bd2757a03a34204372010e..869585f2a2ff2cbf6eff9b97777af0f06a8f117e 100644
--- a/ui/webui/resources/js/cr/ui/focus_grid.js
+++ b/ui/webui/resources/js/cr/ui/focus_grid.js
@@ -65,7 +65,6 @@ cr.define('cr.ui', function() {
row.makeRowActive(row.contains(e.target));
});
- e.preventDefault();
Dan Beam 2015/02/05 19:31:10 when/why was this added?
hcarmona 2015/02/05 21:16:09 This was added as part of the downloads changes. I
Dan Beam 2015/02/05 21:20:36 are you sure you're not confusing preventDefault()
return true;
},
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698