 Chromium Code Reviews
 Chromium Code Reviews Issue 879233003:
  Initial RemoteCommandService  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@remote-commands
    
  
    Issue 879233003:
  Initial RemoteCommandService  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@remote-commands| Index: components/policy/core/common/cloud/cloud_policy_core.h | 
| diff --git a/components/policy/core/common/cloud/cloud_policy_core.h b/components/policy/core/common/cloud/cloud_policy_core.h | 
| index c8e6e5987718640fc7a64f52aba25886a23e74ba..a63f0917df66966fb08ce01a58cf0420fe6b4422 100644 | 
| --- a/components/policy/core/common/cloud/cloud_policy_core.h | 
| +++ b/components/policy/core/common/cloud/cloud_policy_core.h | 
| @@ -26,6 +26,8 @@ class CloudPolicyClient; | 
| class CloudPolicyRefreshScheduler; | 
| class CloudPolicyService; | 
| class CloudPolicyStore; | 
| +class RemoteCommandsFactory; | 
| +class RemoteCommandsService; | 
| // CloudPolicyCore glues together the ingredients that are essential for | 
| // obtaining a fully-functional cloud policy system: CloudPolicyClient and | 
| @@ -73,12 +75,24 @@ class POLICY_EXPORT CloudPolicyCore { | 
| return refresh_scheduler_.get(); | 
| } | 
| + RemoteCommandsService* remote_commands_service() { | 
| + return remote_commands_service_.get(); | 
| + } | 
| + const RemoteCommandsService* remote_commands_service() const { | 
| + return remote_commands_service_.get(); | 
| + } | 
| + | 
| // Initializes the cloud connection. | 
| void Connect(scoped_ptr<CloudPolicyClient> client); | 
| // Shuts down the cloud connection. | 
| void Disconnect(); | 
| + // Starts a remote commands service, with provided factory. Will attempts to | 
| 
bartfab (slow)
2015/02/28 00:01:22
Nit 1: s/with/with the/
Nit 2: s/attempts/attempt/
 
binjin
2015/02/28 02:18:05
Done.
 | 
| + // fetch commands immediately and thus requiring the cloud policy client to be | 
| 
bartfab (slow)
2015/02/28 00:01:22
Nit: s/ and/,/
 
binjin
2015/02/28 02:18:05
Done.
 | 
| + // registered. | 
| + void StartRemoteCommandsService(scoped_ptr<RemoteCommandsFactory> factory); | 
| + | 
| // Requests a policy refresh to be performed soon. This may apply throttling, | 
| // and the request may not be immediately sent. | 
| void RefreshSoon(); | 
| @@ -108,6 +122,7 @@ class POLICY_EXPORT CloudPolicyCore { | 
| scoped_ptr<CloudPolicyClient> client_; | 
| scoped_ptr<CloudPolicyService> service_; | 
| scoped_ptr<CloudPolicyRefreshScheduler> refresh_scheduler_; | 
| + scoped_ptr<RemoteCommandsService> remote_commands_service_; | 
| scoped_ptr<IntegerPrefMember> refresh_delay_; | 
| ObserverList<Observer, true> observers_; |