Initial RemoteCommandService

components/policy/core/common/cloud/cloud_policy_core.cc

Index: components/policy/core/common/cloud/cloud_policy_core.cc
diff --git a/components/policy/core/common/cloud/cloud_policy_core.cc b/components/policy/core/common/cloud/cloud_policy_core.cc
index dd9f46eb30158c901649bfd15db83b41352e2d54..19e1470a170d801164b4fd3065fe769556e82865 100644
--- a/components/policy/core/common/cloud/cloud_policy_core.cc
+++ b/components/policy/core/common/cloud/cloud_policy_core.cc
@@ -11,6 +11,8 @@
 #include "components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h"
 #include "components/policy/core/common/cloud/cloud_policy_service.h"
 #include "components/policy/core/common/cloud/cloud_policy_store.h"
+#include "components/policy/core/common/remote_commands/remote_commands_factory.h"
+#include "components/policy/core/common/remote_commands/remote_commands_service.h"
 
 namespace policy {
 
@@ -46,6 +48,18 @@ void CloudPolicyCore::Disconnect() {
   client_.reset();
 }
 
+void CloudPolicyCore::StartRemoteCommandsService(
+    scoped_ptr<RemoteCommandsFactory> factory) {
+  DCHECK(client_);

[bartfab (slow), 2015/02/28 00:01:22]

Nit 1: #include "base/logging.h"
Nit 2: Is it worth DCHECK()ing that the client is registered?

[binjin, 2015/02/28 02:18:05]

1. Done.
2. Not sure, but I didn't see any guarantee regarding this. 

[bartfab (slow), 2015/03/10 16:09:20]

remote_commands_service_->FetchRemoteCommands() a few lines down will trigger
CloudPolicyClient::FetchRemoteCommands(), which CHECK()s that is_registered() ==
true. So it is a hard requirement that the client be requirement. We may want to
CHECK() it early here, but I do not feel strongly about it.

[binjin, 2015/03/12 11:03:15]

Acknowledged.

+  DCHECK(factory);
+
+  remote_commands_service_.reset(
+      new RemoteCommandsService(factory.Pass(), client_.get()));
+
+  // Do an initial remote commands fetching immediately.

[bartfab (slow), 2015/02/28 00:01:22]

Nit: s/fetching/fetch/

[binjin, 2015/02/28 02:18:05]

Done.

+  remote_commands_service_->FetchRemoteCommands();
+}
+
 void CloudPolicyCore::RefreshSoon() {
   if (refresh_scheduler_)
     refresh_scheduler_->RefreshSoon();