Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 879213003: Load setter from map descriptor instead of embedding it in handler. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Load setter from map descriptor instead of embedding it in handler. BUG=v8:3629 LOG=N Committed: https://crrev.com/b3de173d16affe8121761008f6b3267eea23cbf9 Cr-Commit-Position: refs/heads/master@{#26306}

Patch Set 1 #

Patch Set 2 : fix arm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -40 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 3 chunks +10 lines, -5 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +6 lines, -4 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL. This is similar to https://codereview.chromium.org/872723003/
5 years, 10 months ago (2015-01-28 10:04:09 UTC) #2
Igor Sheludko
lgtm
5 years, 10 months ago (2015-01-28 12:00:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879213003/20001
5 years, 10 months ago (2015-01-28 12:17:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 12:45:03 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 12:45:11 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3de173d16affe8121761008f6b3267eea23cbf9
Cr-Commit-Position: refs/heads/master@{#26306}

Powered by Google App Engine
This is Rietveld 408576698